linux-kernel - Re: [PATCH v2] arm64: dts: zii-ultra: update MDIO speed and preamble device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOMZO5BYDXbVUKad4Cn0fauGMEFu4ZPSOwunrFxMq7+bDYPtMw@mail.gmail.com>
Date:   Tue, 7 Jul 2020 21:41:11 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Chris Healy <cphealy@...il.com>
Cc:     Rob Herring <robh+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>,
        Sascha Hauer <s.hauer@...gutronix.de>,
        NXP Linux Team <linux-imx@....com>,
        Andrey Smirnov <andrew.smirnov@...il.com>,
        Lucas Stach <l.stach@...gutronix.de>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" 
        <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] arm64: dts: zii-ultra: update MDIO speed and preamble device

Hi Chris,

On Tue, Jul 7, 2020 at 9:32 PM Chris Healy <cphealy@...il.com> wrote:

>                 #address-cells = <1>;
>                 #size-cells = <0>;
>                 status = "okay";
> +               suppress-preamble;
> +               clock-frequency = <12500000>;

Sorry, I missed this in the previous review.

The recommendation is to have status = okay as the last property.

Please move suppress-preamble and clock-frequency = <12500000> prior
to status = "okay"