linux-kernel - Re: [PATCH -next] Documentation/vm: fix tables in arch_pgtable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b738eae9-79b7-60d6-0d8e-0c57d23d4e41@arm.com>
Date:   Wed, 8 Jul 2020 10:39:38 +0530
From:   Anshuman Khandual <anshuman.khandual@....com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Linux MM <linux-mm@...ck.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        Jonathan Corbet <corbet@....net>
Cc:     Mike Rapoport <rppt@...nel.org>,
        "linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>
Subject: Re: [PATCH -next] Documentation/vm: fix tables in
 arch_pgtable_helpers



On 07/08/2020 07:36 AM, Randy Dunlap wrote:
> On 7/7/20 6:22 PM, Anshuman Khandual wrote:
>>
>>
>> On 07/08/2020 06:37 AM, Randy Dunlap wrote:
>>> From: Randy Dunlap <rdunlap@...radead.org>
>>>
>>> Make the tables be presented as tables in the generated output files
>>> (the line drawing did not present well).
>>>
>>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>>> Cc: Jonathan Corbet <corbet@....net>
>>> Cc: linux-doc@...r.kernel.org
>>> Cc: Anshuman Khandual <anshuman.khandual@....com>
>>> Cc: Mike Rapoport <rppt@...nel.org>
>>> Cc: linux-arch@...r.kernel.org
>>> Cc: linux-mm@...ck.org
>>> Cc: Andrew Morton <akpm@...ux-foundation.org>
>>> ---
>>>  Documentation/vm/arch_pgtable_helpers.rst |  333 ++++++--------------
>>>  1 file changed, 116 insertions(+), 217 deletions(-)
>>
>> Do you have a git URL some where to see these new output ? This
>> documentation is also useful when reading from a terminal where
>> these manual line drawing tables make sense.
>>
> 
> No, I don't have a git URL.
> You can go to
> https://drive.google.com/file/d/1FO6lCRKldzESwLdylvY8tw10dOBvwz84/view?usp=sharing
> 
> I had to Download the file and then view it locally. I couldn't get Google Drive
> to display it for me as html (only as text).

I could see it locally as well on a browser and the table looks the same
way like those current manual ones on a terminal, so looks good to me.

> 
> I understand about reading tables at a terminal.
> This file could have been a txt file for that, but it's not. It's a RsT file.

Thats right. All files in Documentation/vm/ are .rst type, hence would
not like to have a .txt type in there.

> 
> If you want to leave it as is, please fix these warnings:

Thats right. Can not have in both ways. Lets stick with .rst and change
as required.