linux-kernel - Re: [PATCH] rds: send: Replace sg++ with sg = sg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200708053418.GP207186@unreal>
Date:   Wed, 8 Jul 2020 08:34:18 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Xu Wang <vulab@...as.ac.cn>
Cc:     santosh.shilimkar@...cle.com, davem@...emloft.net, kuba@...nel.org,
        netdev@...r.kernel.org, linux-rdma@...r.kernel.org,
        rds-devel@....oracle.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rds: send: Replace sg++ with sg = sg_next(sg)

On Wed, Jul 08, 2020 at 03:42:52AM +0000, Xu Wang wrote:
> Replace sg++ with sg = sg_next(sg).
>
> Signed-off-by: Xu Wang <vulab@...as.ac.cn>
> ---
>  net/rds/send.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/rds/send.c b/net/rds/send.c
> index 68e2bdb08fd0..57d03a6753de 100644
> --- a/net/rds/send.c
> +++ b/net/rds/send.c
> @@ -387,7 +387,7 @@ int rds_send_xmit(struct rds_conn_path *cp)
>  				ret -= tmp;
>  				if (cp->cp_xmit_data_off == sg->length) {
>  					cp->cp_xmit_data_off = 0;
> -					sg++;
> +					sg = sg_next(sg);

What about rest cases?

➜  kernel git:(rdma-next) git grep "sg++" net/rds/
net/rds/message.c:              sg++;
net/rds/message.c:                      sg++;
net/rds/message.c:                      sg++;
net/rds/send.c:                                 sg++;
net/rds/tcp_send.c:                     sg++;

Thanks

>  					cp->cp_xmit_sg++;
>  					BUG_ON(ret != 0 && cp->cp_xmit_sg ==
>  					       rm->data.op_nents);
> --
> 2.17.1
>