linux-kernel - Re: [PATCH 09/10] scsi: libfc: fc_disc: Fix-up some incorrectly referenced function parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd81c7d2-0a65-fb8e-d16f-350e93ed66ea@suse.de>
Date:   Wed, 8 Jul 2020 08:30:50 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     Lee Jones <lee.jones@...aro.org>, jejb@...ux.ibm.com,
        martin.petersen@...cle.com
Cc:     linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org
Subject: Re: [PATCH 09/10] scsi: libfc: fc_disc: Fix-up some incorrectly
 referenced function parameters

On 7/7/20 4:00 PM, Lee Jones wrote:
> Fixes the following W=1 kernel build warning(s):
> 
>   drivers/scsi/libfc/fc_disc.c:343: warning: Function parameter or member 'disc' not described in 'fc_disc_gpn_ft_req'
>   drivers/scsi/libfc/fc_disc.c:343: warning: Excess function parameter 'lport' description in 'fc_disc_gpn_ft_req'
>   drivers/scsi/libfc/fc_disc.c:380: warning: Function parameter or member 'disc' not described in 'fc_disc_gpn_ft_parse'
>   drivers/scsi/libfc/fc_disc.c:380: warning: Excess function parameter 'lport' description in 'fc_disc_gpn_ft_parse'
>   drivers/scsi/libfc/fc_disc.c:498: warning: Function parameter or member 'disc_arg' not described in 'fc_disc_gpn_ft_resp'
>   drivers/scsi/libfc/fc_disc.c:498: warning: Excess function parameter 'lp_arg' description in 'fc_disc_gpn_ft_resp'
> 
> Cc: Hannes Reinecke <hare@...e.de>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>   drivers/scsi/libfc/fc_disc.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/libfc/fc_disc.c b/drivers/scsi/libfc/fc_disc.c
> index 2b865c6423e29..428f40cfd1c36 100644
> --- a/drivers/scsi/libfc/fc_disc.c
> +++ b/drivers/scsi/libfc/fc_disc.c
> @@ -337,7 +337,7 @@ static void fc_disc_error(struct fc_disc *disc, struct fc_frame *fp)
>   
>   /**
>    * fc_disc_gpn_ft_req() - Send Get Port Names by FC-4 type (GPN_FT) request
> - * @lport: The discovery context
> + * @disc: The discovery context
>    */
>   static void fc_disc_gpn_ft_req(struct fc_disc *disc)
>   {
> @@ -370,7 +370,7 @@ static void fc_disc_gpn_ft_req(struct fc_disc *disc)
>   
>   /**
>    * fc_disc_gpn_ft_parse() - Parse the body of the dNS GPN_FT response.
> - * @lport: The local port the GPN_FT was received on
> + * @disc:  The descovery context
>    * @buf:   The GPN_FT response buffer
>    * @len:   The size of response buffer
>    *
> @@ -488,7 +488,7 @@ static void fc_disc_timeout(struct work_struct *work)
>    * fc_disc_gpn_ft_resp() - Handle a response frame from Get Port Names (GPN_FT)
>    * @sp:	    The sequence that the GPN_FT response was received on
>    * @fp:	    The GPN_FT response frame
> - * @lp_arg: The discovery context
> + * @disc_arg: The discovery context
>    *
>    * Locking Note: This function is called without disc mutex held, and
>    *		 should do all its processing with the mutex held
> 
Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke            Teamlead Storage & Networking
hare@...e.de                               +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer