linux-kernel - Re: [PATCH] xfs: Use fallthrough pseudo-keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200708065512.GN2005@dread.disaster.area>
Date:   Wed, 8 Jul 2020 16:55:12 +1000
From:   Dave Chinner <david@...morbit.com>
To:     Joe Perches <joe@...ches.com>
Cc:     "Darrick J. Wong" <darrick.wong@...cle.com>,
        "Gustavo A. R. Silva" <gustavoars@...nel.org>,
        linux-xfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] xfs: Use fallthrough pseudo-keyword

On Tue, Jul 07, 2020 at 06:48:29PM -0700, Joe Perches wrote:
> On Tue, 2020-07-07 at 13:50 -0700, Darrick J. Wong wrote:
> > On Tue, Jul 07, 2020 at 03:05:04PM -0500, Gustavo A. R. Silva wrote:
> > > Replace the existing /* fall through */ comments and its variants with
> > > the new pseudo-keyword macro fallthrough[1]. Also, remove unnecessary
> > > fall-through markings when it is the case.
> []
> > I don't get it, what's the point?  Are gcc/clang
> > refusing to support -Wimplicit-fallthrough=[1-4] past a certain date?
> 
> clang doesn't support comments

So fix the damn compiler.

-Dave
-- 
Dave Chinner
david@...morbit.com