linux-kernel - Re: [PATCH] ALSA: Use fallthrough pseudo-keyword

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5htuyibhtl.wl-tiwai@suse.de>
Date:   Wed, 08 Jul 2020 09:13:10 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     "Gustavo A. R. Silva" <gustavoars@...nel.org>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>
Subject: Re: [PATCH] ALSA: Use fallthrough pseudo-keyword

On Tue, 07 Jul 2020 19:28:47 +0200,
Gustavo A. R. Silva wrote:
> --- a/sound/isa/msnd/msnd_pinnacle_mixer.c
> +++ b/sound/isa/msnd/msnd_pinnacle_mixer.c
> @@ -219,8 +219,7 @@ static int snd_msndmix_set(struct snd_msnd *dev, int d, int left, int right)
>  	case MSND_MIXER_VOLUME:		/* master volume */
>  		writew(wLeft, dev->SMA + SMA_wCurrMastVolLeft);
>  		writew(wRight, dev->SMA + SMA_wCurrMastVolRight);
> -		/* fall through */
> -
> +		fallthrough;
>  	case MSND_MIXER_AUX:			/* aux pot control */
>  		/* scaled by master volume */
>  		/* fall through */

Any reason to leave this?


thanks,

Takashi