linux-kernel - Re: [PATCH 02/10] gpio: gpio-altera: Add missing kerneldoc entry and demote comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZ-0L=ONVbneB5pUoDkwS0btT2FnnDWc7YL0LsZj4fhWw@mail.gmail.com>
Date:   Wed, 8 Jul 2020 09:15:01 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Joyce Ooi <joyce.ooi@...el.com>,
        Tien Hock Loh <thloh@...era.com>
Subject: Re: [PATCH 02/10] gpio: gpio-altera: Add missing kerneldoc entry and
 demote comment

On Tue, Jun 30, 2020 at 3:33 PM Lee Jones <lee.jones@...aro.org> wrote:

> 'struct altera_gpio_chip's 'irq_chip' property is undocumented.  So
> add property description to the struct's kerneldoc header.  Also
> demote comment block which is clearly not in kerneldoc format.
>
> Fixes the following W=1 warnings:
>
>  drivers/gpio/gpio-altera.c:34: warning: Function parameter or member 'irq_chip' not described in 'altera_gpio_chip'
>  drivers/gpio/gpio-altera.c:78: warning: Function parameter or member 'd' not described in 'altera_gpio_irq_set_type'
>  drivers/gpio/gpio-altera.c:78: warning: Function parameter or member 'type' not described in 'altera_gpio_irq_set_type'
>
> Cc: Joyce Ooi <joyce.ooi@...el.com>
> Cc: Tien Hock Loh <thloh@...era.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Patch applied!

Yours,
Linus Walleij