linux-kernel - Re: [PATCH 06/10] gpio: gpio-syscon: Fix formatting issues which confuse kerneldoc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdbszVdmRY4V=Z=vVPAdbx4q=26F-OcnZu2w3-BNk+0ohQ@mail.gmail.com>
Date:   Wed, 8 Jul 2020 09:18:29 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Alexander Shiyan <shc_work@...l.ru>
Subject: Re: [PATCH 06/10] gpio: gpio-syscon: Fix formatting issues which
 confuse kerneldoc

On Tue, Jun 30, 2020 at 3:33 PM Lee Jones <lee.jones@...aro.org> wrote:

> Kerneldoc expects struct properties to be documented using the syntax
> '@.*: ', but no '@' has been provided in 'struct syscon_gpio_data's
> header.  Add them to stop confusing kerneldoc.
>
> Fixes the following W=1 warnings:
>
>  drivers/gpio/gpio-syscon.c:48: warning: Function parameter or member 'compatible' not described in 'syscon_gpio_data'
>  drivers/gpio/gpio-syscon.c:48: warning: Function parameter or member 'flags' not described in 'syscon_gpio_data'
>  drivers/gpio/gpio-syscon.c:48: warning: Function parameter or member 'bit_count' not described in 'syscon_gpio_data'
>  drivers/gpio/gpio-syscon.c:48: warning: Function parameter or member 'dat_bit_offset' not described in 'syscon_gpio_data'
>  drivers/gpio/gpio-syscon.c:48: warning: Function parameter or member 'dir_bit_offset' not described in 'syscon_gpio_data'
>  drivers/gpio/gpio-syscon.c:48: warning: Function parameter or member 'set' not described in 'syscon_gpio_data'
>
> Cc: Alexander Shiyan <shc_work@...l.ru>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>

Patch applied!

Yours,
Linus Walleij