linux-kernel - Re: [PATCH] mfd: axp20x: Use #ifdef for checking CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 8 Jul 2020 08:29:57 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Chen-Yu Tsai <wens@...e.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: axp20x: Use #ifdef for checking CONFIG_ACPI

On Wed, 08 Jul 2020, Krzysztof Kozlowski wrote:

> Use #ifdef directive to check whether config symbol is defined and to
> fix warning:
> 
>     drivers/mfd/axp20x-i2c.c:82:5: warning: "CONFIG_ACPI" is not defined [-Wundef]
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>
> ---
>  drivers/mfd/axp20x-i2c.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

This is already fixed (3 times now). :)

Thanks anyway.

> diff --git a/drivers/mfd/axp20x-i2c.c b/drivers/mfd/axp20x-i2c.c
> index bd271fbe1ec1..3c930316d48b 100644
> --- a/drivers/mfd/axp20x-i2c.c
> +++ b/drivers/mfd/axp20x-i2c.c
> @@ -79,7 +79,7 @@ static const struct i2c_device_id axp20x_i2c_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, axp20x_i2c_id);
>  
> -#if CONFIG_ACPI
> +#ifdef CONFIG_ACPI
>  static const struct acpi_device_id axp20x_i2c_acpi_match[] = {
>  	{
>  		.id = "INT33F4",

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog