linux-kernel - Re: [PATCH 11/15] mmc: host: sdhci-of-arasan: Correct formatting and provide missing function arg(s)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e815842-626f-f981-7ef6-818a3e27974d@xilinx.com>
Date:   Wed, 8 Jul 2020 09:53:49 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Lee Jones <lee.jones@...aro.org>, ulf.hansson@...aro.org
Cc:     linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Adrian Hunter <adrian.hunter@...el.com>,
        Michal Simek <michal.simek@...inx.com>,
        Xiaobo Xie <X.Xie@...escale.com>,
        Anton Vorontsov <avorontsov@...mvista.com>,
        Soeren Brinkmann <soren.brinkmann@...inx.com>
Subject: Re: [PATCH 11/15] mmc: host: sdhci-of-arasan: Correct formatting and
 provide missing function arg(s)



On 01. 07. 20 14:46, Lee Jones wrote:
> Kerneldoc expects arg descriptions to be in the format '@.*: '.  If either
> the '@' or the ':' is omitted then kerneldoc complains that the description
> is missing.  Add the missing ':' here and provide a new description for
> 'value'.
> 
> Fixes the following kernel build W=1 warnings:
> 
>  drivers/mmc/host/sdhci-of-arasan.c:1394: warning: Function parameter or member 'host' not described in 'sdhci_arasan_update_support64b'
>  drivers/mmc/host/sdhci-of-arasan.c:1394: warning: Function parameter or member 'value' not described in 'sdhci_arasan_update_support64b'
>  drivers/mmc/host/sdhci-msm.c:1887:6: warning: no previous prototype for ‘sdhci_msm_dump_vendor_regs’ [-Wmissing-prototypes]
> 
> Cc: Adrian Hunter <adrian.hunter@...el.com>
> Cc: Michal Simek <michal.simek@...inx.com>
> Cc: Xiaobo Xie <X.Xie@...escale.com>
> Cc: Anton Vorontsov <avorontsov@...mvista.com>
> Cc: Soeren Brinkmann <soren.brinkmann@...inx.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> ---
>  drivers/mmc/host/sdhci-of-arasan.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index db9b544465cda..260e06e238f7e 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -1388,7 +1388,8 @@ static void sdhci_arasan_unregister_sdclk(struct device *dev)
>   * - For Keem Bay, it is required to clear this bit. Its default value is 1'b1.
>   *   Keem Bay does not support 64-bit access.
>   *
> - * @host		The sdhci_host
> + * @host:		The sdhci_host
> + * @value:		The value to write
>   */
>  static void sdhci_arasan_update_support64b(struct sdhci_host *host, u32 value)
>  {
> 

Acked-by: Michal Simek <michal.simek@...inx.com>

Thanks,
Michal