linux-kernel - RE: [EXT] [PATCH 4/5] net: fec: get rid of redundant code in fec_ptp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Jul 2020 08:57:07 +0000
From:   Andy Duan <fugang.duan@....com>
To:     Sergey Organov <sorganov@...il.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
Subject: RE: [EXT] [PATCH  4/5] net: fec: get rid of redundant code in
 fec_ptp_set()

From: Sergey Organov <sorganov@...il.com> Sent: Wednesday, July 8, 2020 4:49 PM
> Andy Duan <fugang.duan@....com> writes:
> 
> > From: Sergey Organov <sorganov@...il.com> Sent: Tuesday, July 7, 2020
> > 10:43 PM
> >> Andy Duan <fugang.duan@....com> writes:
> >>
> >> > From: Sergey Organov <sorganov@...il.com> Sent: Monday, July 6,
> >> > 2020
> >> 10:26 PM
> >> >> Code of the form "if(x) x = 0" replaced with "x = 0".
> >> >>
> >> >> Code of the form "if(x == a) x = a" removed.
> >> >>
> >> >> Signed-off-by: Sergey Organov <sorganov@...il.com>
> >> >> ---
> >> >>  drivers/net/ethernet/freescale/fec_ptp.c | 4 +---
> >> >>  1 file changed, 1 insertion(+), 3 deletions(-)
> >> >>
> >> >> diff --git a/drivers/net/ethernet/freescale/fec_ptp.c
> >> >> b/drivers/net/ethernet/freescale/fec_ptp.c
> >> >> index e455343..4152cae 100644
> >> >> --- a/drivers/net/ethernet/freescale/fec_ptp.c
> >> >> +++ b/drivers/net/ethernet/freescale/fec_ptp.c
> >> >> @@ -485,9 +485,7 @@ int fec_ptp_set(struct net_device *ndev,
> >> >> struct
> >> ifreq
> >> >> *ifr)
> >> >>
> >> >>         switch (config.rx_filter) {
> >> >>         case HWTSTAMP_FILTER_NONE:
> >> >> -               if (fep->hwts_rx_en)
> >> >> -                       fep->hwts_rx_en = 0;
> >> >> -               config.rx_filter = HWTSTAMP_FILTER_NONE;
 
The original patch seems fine. Thanks!

For the patch: Acked-by: Fugang Duan <fugang.duan@....com>