linux-kernel - Re: [PATCH] fs: ceph: Remove unnecessary cast in kfree()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOi1vP-+raGXYPkumWSbO-YdcMw_hw7VR=K2npPc3NAQC1_J2A@mail.gmail.com>
Date:   Wed, 8 Jul 2020 12:38:53 +0200
From:   Ilya Dryomov <idryomov@...il.com>
To:     Xu Wang <vulab@...as.ac.cn>
Cc:     Jeff Layton <jlayton@...nel.org>,
        Ceph Development <ceph-devel@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs: ceph: Remove unnecessary cast in kfree()

On Wed, Jul 8, 2020 at 9:27 AM Xu Wang <vulab@...as.ac.cn> wrote:
>
> Remove unnecassary casts in the argument to kfree.
>
> Signed-off-by: Xu Wang <vulab@...as.ac.cn>
> ---
>  fs/ceph/xattr.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/fs/ceph/xattr.c b/fs/ceph/xattr.c
> index 71ee34d160c3..3a733ac33d9b 100644
> --- a/fs/ceph/xattr.c
> +++ b/fs/ceph/xattr.c
> @@ -497,10 +497,10 @@ static int __set_xattr(struct ceph_inode_info *ci,
>                 kfree(*newxattr);
>                 *newxattr = NULL;
>                 if (xattr->should_free_val)
> -                       kfree((void *)xattr->val);
> +                       kfree(xattr->val);
>
>                 if (update_xattr) {
> -                       kfree((void *)name);
> +                       kfree(name);
>                         name = xattr->name;
>                 }
>                 ci->i_xattrs.names_size -= xattr->name_len;
> @@ -566,9 +566,9 @@ static void __free_xattr(struct ceph_inode_xattr *xattr)
>         BUG_ON(!xattr);
>
>         if (xattr->should_free_name)
> -               kfree((void *)xattr->name);
> +               kfree(xattr->name);
>         if (xattr->should_free_val)
> -               kfree((void *)xattr->val);
> +               kfree(xattr->val);
>
>         kfree(xattr);
>  }
> @@ -582,9 +582,9 @@ static int __remove_xattr(struct ceph_inode_info *ci,
>         rb_erase(&xattr->node, &ci->i_xattrs.index);
>
>         if (xattr->should_free_name)
> -               kfree((void *)xattr->name);
> +               kfree(xattr->name);
>         if (xattr->should_free_val)
> -               kfree((void *)xattr->val);
> +               kfree(xattr->val);
>
>         ci->i_xattrs.names_size -= xattr->name_len;
>         ci->i_xattrs.vals_size -= xattr->val_len;

Applied.

Thanks,

                Ilya