linux-kernel - Re: [PATCH] Replace HTTP links with HTTPS ones: ATMEL MACB ETHERNET DRIVER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <caf7b073-a254-44a9-9466-b919b03596cf@microchip.com>
Date:   Wed, 8 Jul 2020 13:01:51 +0200
From:   Nicolas Ferre <nicolas.ferre@...rochip.com>
To:     "Alexander A. Klimov" <grandmaster@...klimov.de>,
        <davem@...emloft.net>, <kuba@...nel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: ATMEL MACB ETHERNET
 DRIVER

On 08/07/2020 at 12:35, Alexander A. Klimov wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
> 
> Deterministic algorithm:
> For each file:
>    If not .svg:
>      For each line:
>        If doesn't contain `\bxmlns\b`:
>          For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
>            If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
>              If both the HTTP and HTTPS versions
>              return 200 OK and serve the same content:
>                Replace HTTP with HTTPS.
> 
> Signed-off-by: Alexander A. Klimov <grandmaster@...klimov.de>

The links go to Cadence. If people from Cadence want to change 
something, don't hesitate to speak out. On my side:
Acked-by: Nicolas Ferre <nicolas.ferre@...rochip.com>

> ---
>   Continuing my work started at 93431e0607e5.
>   See also: git log --oneline '--author=Alexander A. Klimov <grandmaster@...klimov.de>' v5.7..master
>   (Actually letting a shell for loop submit all this stuff for me.)
> 
>   If there are any URLs to be removed completely or at least not HTTPSified:
>   Just clearly say so and I'll *undo my change*.
>   See also: https://lkml.org/lkml/2020/6/27/64
> 
>   If there are any valid, but yet not changed URLs:
>   See: https://lkml.org/lkml/2020/6/26/837
> 
>   If you apply the patch, please let me know.
> 
> 
>   drivers/net/ethernet/cadence/macb_pci.c | 2 +-
>   drivers/net/ethernet/cadence/macb_ptp.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/cadence/macb_pci.c b/drivers/net/ethernet/cadence/macb_pci.c
> index 617b3b728dd0..cd7d0332cba3 100644
> --- a/drivers/net/ethernet/cadence/macb_pci.c
> +++ b/drivers/net/ethernet/cadence/macb_pci.c
> @@ -2,7 +2,7 @@
>   /**
>    * Cadence GEM PCI wrapper.
>    *
> - * Copyright (C) 2016 Cadence Design Systems - http://www.cadence.com
> + * Copyright (C) 2016 Cadence Design Systems - https://www.cadence.com
>    *
>    * Authors: Rafal Ozieblo <rafalo@...ence.com>
>    *         Bartosz Folta <bfolta@...ence.com>
> diff --git a/drivers/net/ethernet/cadence/macb_ptp.c b/drivers/net/ethernet/cadence/macb_ptp.c
> index 43a3f0dbf857..31ebf3ee7ec0 100644
> --- a/drivers/net/ethernet/cadence/macb_ptp.c
> +++ b/drivers/net/ethernet/cadence/macb_ptp.c
> @@ -2,7 +2,7 @@
>   /**
>    * 1588 PTP support for Cadence GEM device.
>    *
> - * Copyright (C) 2017 Cadence Design Systems - http://www.cadence.com
> + * Copyright (C) 2017 Cadence Design Systems - https://www.cadence.com
>    *
>    * Authors: Rafal Ozieblo <rafalo@...ence.com>
>    *          Bartosz Folta <bfolta@...ence.com>
> --
> 2.27.0
> 


-- 
Nicolas Ferre