[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200708110301.GB1551@shell.armlinux.org.uk>
Date: Wed, 8 Jul 2020 12:03:01 +0100
From: Russell King - ARM Linux admin <linux@...linux.org.uk>
To: Ondrej Jirman <megous@...ous.com>
Cc: linux-sunxi@...glegroups.com,
Amit Kucheria <amit.kucheria@...durent.com>,
"open list:ALLWINNER THERMAL DRIVER" <linux-pm@...r.kernel.org>,
Yangtao Li <tiny.windzz@...il.com>,
Daniel Lezcano <daniel.lezcano@...aro.org>,
open list <linux-kernel@...r.kernel.org>,
Maxime Ripard <mripard@...nel.org>,
Vasily Khoruzhick <anarsoul@...il.com>,
Chen-Yu Tsai <wens@...e.org>, Zhang Rui <rui.zhang@...el.com>,
"moderated list:ARM/Allwinner sunXi SoC support"
<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] thermal: sun8i: Be loud when probe fails
On Wed, Jul 08, 2020 at 12:55:27PM +0200, Ondrej Jirman wrote:
> I noticed several mobile Linux distributions failing to enable the
> thermal regulation correctly, because the kernel is silent
> when thermal driver fails to probe. Add enough error reporting
> to debug issues and warn users in case thermal sensor is failing
> to probe.
>
> Failing to notify users means, that SoC can easily overheat under
> load.
>
> Signed-off-by: Ondrej Jirman <megous@...ous.com>
> ---
> drivers/thermal/sun8i_thermal.c | 55 ++++++++++++++++++++++++++-------
> 1 file changed, 43 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/thermal/sun8i_thermal.c b/drivers/thermal/sun8i_thermal.c
> index 74d73be16496..9065e79ae743 100644
> --- a/drivers/thermal/sun8i_thermal.c
> +++ b/drivers/thermal/sun8i_thermal.c
> @@ -287,8 +287,12 @@ static int sun8i_ths_calibrate(struct ths_device *tmdev)
>
> calcell = devm_nvmem_cell_get(dev, "calibration");
> if (IS_ERR(calcell)) {
> + dev_err(dev, "Failed to get calibration nvmem cell (%ld)\n",
> + PTR_ERR(calcell));
Consider using:
dev_err(dev, "Failed to get calibration nvmem cell (%pe)\n",
calcell);
which means the kernel can print the symbolic errno value.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
Powered by blists - more mailing lists