linux-kernel - Re: [PATCH] spi: use kthread_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200708112825.GC4751@alley>
Date:   Wed, 8 Jul 2020 13:28:25 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     Marek Szyprowski <m.szyprowski@...sung.com>
Cc:     linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-samsung-soc@...r.kernel.org, Mark Brown <broonie@...nel.org>,
        Zhang Qiang <qiang.zhang@...driver.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
Subject: Re: [PATCH] spi: use kthread_create_worker() helper

On Wed 2020-07-08 09:09:00, Marek Szyprowski wrote:
> Since commit 4977caef05aa ("kthread: work could not be queued when worker
> being destroyed")

This commit should disappear from linux-next soon. We did not expect
that it would cause these warnings. We first want to fix the callers
before we put it back.

> there is a warning when kworker is used without the
> internal 'task' entry properly initialized. Fix this by using
> a kthread_create_worker() helper instead of open-coding a kworker
> initialization.

But the fix is great and makes sense on its own.

The use of kthread_create_worker() simplifies the code. It uses
the kthread worker API the right way. It will eventually allow
to remove the FIXME in kthread_worker_fn() and add more consistency
checks.

I would use the above reasoning instead of the backtrace in the commit
message. And feel free to use:

Reviewed-by: Petr Mladek <pmladek@...e.com>

Best Regards,
Petr Mladek