linux-kernel - Re: [PATCH] Replace HTTP links with HTTPS ones: KMOD KERNEL MODULE LOADER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Jul 2020 11:53:24 +0000
From:   Luis Chamberlain <mcgrof@...nel.org>
To:     "Alexander A. Klimov" <grandmaster@...klimov.de>, shuah@...nel.org
Cc:     linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH] Replace HTTP links with HTTPS ones: KMOD KERNEL MODULE
 LOADER - USERMODE HELPER

On Wed, Jul 08, 2020 at 09:13:37AM +0200, Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
> 
> Deterministic algorithm:
> For each file:
>   If not .svg:
>     For each line:
>       If doesn't contain `\bxmlns\b`:
>         For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
> 	  If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
>             If both the HTTP and HTTPS versions
>             return 200 OK and serve the same content:
>               Replace HTTP with HTTPS.
> 
> Signed-off-by: Alexander A. Klimov <grandmaster@...klimov.de>

Acked-by: Luis Chamberlain <mcgrof@...nel.org>

Shuah, can this go through your tree?

  Luis

> ---
>  tools/testing/selftests/kmod/kmod.sh | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/kmod/kmod.sh b/tools/testing/selftests/kmod/kmod.sh
> index 3702dbcc90a7..84409020a40f 100755
> --- a/tools/testing/selftests/kmod/kmod.sh
> +++ b/tools/testing/selftests/kmod/kmod.sh
> @@ -128,7 +128,7 @@ test_reqs()
>  	if [[ $KMOD_VERSION  -le 19 ]]; then
>  		echo "$0: You need at least kmod 20" >&2
>  		echo "kmod <= 19 is buggy, for details see:" >&2
> -		echo "http://git.kernel.org/cgit/utils/kernel/kmod/kmod.git/commit/libkmod/libkmod-module.c?id=fd44a98ae2eb5eb32161088954ab21e58e19dfc4" >&2
> +		echo "https://git.kernel.org/cgit/utils/kernel/kmod/kmod.git/commit/libkmod/libkmod-module.c?id=fd44a98ae2eb5eb32161088954ab21e58e19dfc4" >&2
>  		exit $ksft_skip
>  	fi
>  
> -- 
> 2.27.0
>