linux-kernel - Re: [PATCH 27/30] scsi: pm8001: pm8001_init: Demote obvious misuse of kerneldoc and update others

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMGffE=v5sx=RsS9i7kNbgn9BbL6LQz2PO1fG2WkCj9P3cDHXQ@mail.gmail.com>
Date:   Wed, 8 Jul 2020 14:17:31 +0200
From:   Jinpu Wang <jinpu.wang@...ud.ionos.com>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        linux-kernel@...r.kernel.org,
        Linux SCSI Mailinglist <linux-scsi@...r.kernel.org>,
        Kumar Santhanam <AnandKumar.Santhanam@...s.com>,
        Sangeetha Gnanasekaran <Sangeetha.Gnanasekaran@...s.com>,
        Nikith Ganigarakoppal <Nikith.Ganigarakoppal@...s.com>
Subject: Re: [PATCH 27/30] scsi: pm8001: pm8001_init: Demote obvious misuse of
 kerneldoc and update others

On Wed, Jul 8, 2020 at 2:03 PM Lee Jones <lee.jones@...aro.org> wrote:
>
> More bitrot issues with function documentation not keeping up with API changes.
>
> Fixes the following W=1 kernel build warning(s):
>
>  drivers/scsi/pm8001/pm8001_init.c:64: warning: cannot understand function prototype: 'const struct pm8001_chip_info pm8001_chips[] = '
>  drivers/scsi/pm8001/pm8001_init.c:86: warning: cannot understand function prototype: 'struct scsi_host_template pm8001_sht = '
>  drivers/scsi/pm8001/pm8001_init.c:115: warning: cannot understand function prototype: 'struct sas_domain_function_template pm8001_transport_ops = '
>  drivers/scsi/pm8001/pm8001_init.c:212: warning: Function parameter or member 'irq' not described in 'pm8001_interrupt_handler_msix'
>  drivers/scsi/pm8001/pm8001_init.c:237: warning: Function parameter or member 'irq' not described in 'pm8001_interrupt_handler_intx'
>  drivers/scsi/pm8001/pm8001_init.c:265: warning: Function parameter or member 'ent' not described in 'pm8001_alloc'
>  drivers/scsi/pm8001/pm8001_init.c:624: warning: Function parameter or member 'pm8001_ha' not described in 'pm8001_init_sas_add'
>  drivers/scsi/pm8001/pm8001_init.c:624: warning: Excess function parameter 'chip_info' description in 'pm8001_init_sas_add'
>  drivers/scsi/pm8001/pm8001_init.c:900: warning: Function parameter or member 'pm8001_ha' not described in 'pm8001_setup_msix'
>  drivers/scsi/pm8001/pm8001_init.c:900: warning: Excess function parameter 'chip_info' description in 'pm8001_setup_msix'
>  drivers/scsi/pm8001/pm8001_init.c:900: warning: Excess function parameter 'irq_handler' description in 'pm8001_setup_msix'
>  drivers/scsi/pm8001/pm8001_init.c:981: warning: Function parameter or member 'pm8001_ha' not described in 'pm8001_request_irq'
>  drivers/scsi/pm8001/pm8001_init.c:981: warning: Excess function parameter 'chip_info' description in 'pm8001_request_irq'
>
> Cc: Jack Wang <jinpu.wang@...ud.ionos.com>
> Cc: Kumar Santhanam <AnandKumar.Santhanam@...s.com>
> Cc: Sangeetha Gnanasekaran <Sangeetha.Gnanasekaran@...s.com>
> Cc: Nikith Ganigarakoppal <Nikith.Ganigarakoppal@...s.com>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
Thanks Lee,
Acked-by: Jack Wang <jinpu.wang@...ud.ionos.com>