linux-kernel - Re: [PATCH 13/30] scsi: libfc: fc_rport: Fix bitrotted function parameter and copy/paste error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Jul 2020 13:25:06 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Johannes Thumshirn <Johannes.Thumshirn@....com>
Cc:     "jejb@...ux.ibm.com" <jejb@...ux.ibm.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        Hannes Reinecke <hare@...e.de>
Subject: Re: [PATCH 13/30] scsi: libfc: fc_rport: Fix bitrotted function
 parameter and copy/paste error

On Wed, 08 Jul 2020, Lee Jones wrote:

> On Wed, 08 Jul 2020, Johannes Thumshirn wrote:
> 
> > On 08/07/2020 14:04, Lee Jones wrote:
> > > Description should state 'remote' port, not 'local'.
> > > 
> > > Fixes the following W=1 kernel build warning(s):
> > > 
> > >  drivers/scsi/libfc/fc_rport.c:1452: warning: Function parameter or member 'rdata_arg' not described in 'fc_rport_logo_resp'
> > >  drivers/scsi/libfc/fc_rport.c:1452: warning: Excess function parameter 'rport_arg' description in 'fc_rport_logo_resp'
> > > 
> > > Cc: Hannes Reinecke <hare@...e.de>
> > > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> > > ---
> > >  drivers/scsi/libfc/fc_rport.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c
> > > index ea99e69d4d89c..18663a82865f9 100644
> > > --- a/drivers/scsi/libfc/fc_rport.c
> > > +++ b/drivers/scsi/libfc/fc_rport.c
> > > @@ -1445,7 +1445,7 @@ static void fc_rport_recv_rtv_req(struct fc_rport_priv *rdata,
> > >   * fc_rport_logo_resp() - Handler for logout (LOGO) responses
> > >   * @sp:	       The sequence the LOGO was on
> > >   * @fp:	       The LOGO response frame
> > > - * @rport_arg: The local port
> > > + * @rdata_arg: The remote port
> > >   */
> > >  static void fc_rport_logo_resp(struct fc_seq *sp, struct fc_frame *fp,
> > >  			       void *rdata_arg)
> > > 
> > 
> > 
> > Please fold this into patch 11
> 
> Yes, will do.

Actually, Martin, is this something you can do when applying, or would
you like me to do it and submit the entire set again?

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog