linux-kernel - Re: [RFC PATCH 0/2] PM / devfreq: Add delayed timer for polling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a3339c58-6350-9298-6053-9dc021170048@arm.com>
Date:   Wed, 8 Jul 2020 15:25:03 +0100
From:   Lukasz Luba <lukasz.luba@....com>
To:     Willy Wolff <willy.mh.wolff.ml@...il.com>,
        Chanwoo Choi <cw00.choi@...sung.com>
Cc:     k.konieczny@...sung.com, krzk@...nel.org, kgene@...nel.org,
        s.nawrocki@...sung.com, b.zolnierkie@...sung.com,
        chanwoo@...nel.org, myungjoo.ham@...sung.com,
        kyungmin.park@...sung.com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [RFC PATCH 0/2] PM / devfreq: Add delayed timer for polling

Hi Willy,

On 7/3/20 1:33 PM, Willy Wolff wrote:
> Hi Chanwoo,
> 
> I think it doesn't help on the benchmark I suggested that is doing only memory
> accesses. With both timer, I have the same timing.
> 
> To test the benchmark with these new patches about timer:
> 
> git clone https://github.com/wwilly/benchmark.git \
>    && cd benchmark \
>    && source env.sh \
>    && ./bench_build.sh \
>    && bash source/scripts/test_dvfs_mem_patched.sh
> 
> The benchmark is set by default to run for 1s, but you can increase this by
> tweaking the script as:
> 
> taskset 8 ./bench_install/bin/microbe_cache 33554431 0 9722222 <TIME in sec> ${little_freq}
> 
> 
> Also, as I reported the issue, would it be possible to add a
> Reported-by: Willy Wolff <willy.mh.wolff.ml@...il.com> ?
> Many thanks in advance.

Thank you for your good work and the benchmark. I hope you will continue
to use it and report some issues. I am going to send a follow up patches
for the DMC and I will add your 'Reported-by'. In the tests I can see
the improvements, but it's worth to consult with you if I understand
the new results correctly.

I think there is still some area for improvements in the devfreq and you
could find the interesting bits to contribute.

Regards,
Lukasz

> 
> 
> Best Regards,
> Willy
>