linux-kernel - Re: [PATCH] drm/amd/display: add dmcub check on RENOIR

Open Source and information security mailing list archives

Date:   Wed, 8 Jul 2020 10:30:52 -0400
From:   "Kazlauskas, Nicholas" <nicholas.kazlauskas@....com>
To:     "Deucher, Alexander" <Alexander.Deucher@....com>,
        Aaron Ma <aaron.ma@...onical.com>,
        "Wentland, Harry" <Harry.Wentland@....com>,
        "Li, Sun peng (Leo)" <Sunpeng.Li@....com>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "mapengyu@...il.com" <mapengyu@...il.com>
Subject: Re: [PATCH] drm/amd/display: add dmcub check on RENOIR

Looks good to me.

Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@....com>

Regards,
Nicholas Kazlauskas

On 2020-07-08 10:15 a.m., Deucher, Alexander wrote:
> [AMD Public Use]
> 
> 
> [AMD Public Use]
> 
> 
> Acked-by: Alex Deucher <alexander.deucher@....com>
> ------------------------------------------------------------------------
> *From:* Aaron Ma <aaron.ma@...onical.com>
> *Sent:* Wednesday, July 8, 2020 4:16 AM
> *To:* Wentland, Harry <Harry.Wentland@....com>; Li, Sun peng (Leo) 
> <Sunpeng.Li@....com>; Deucher, Alexander <Alexander.Deucher@....com>; 
> Koenig, Christian <Christian.Koenig@....com>; airlied@...ux.ie 
> <airlied@...ux.ie>; daniel@...ll.ch <daniel@...ll.ch>; 
> amd-gfx@...ts.freedesktop.org <amd-gfx@...ts.freedesktop.org>; 
> dri-devel@...ts.freedesktop.org <dri-devel@...ts.freedesktop.org>; 
> linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>; 
> mapengyu@...il.com <mapengyu@...il.com>; aaron.ma@...onical.com 
> <aaron.ma@...onical.com>
> *Subject:* [PATCH] drm/amd/display: add dmcub check on RENOIR
> RENOIR loads dmub fw not dmcu, check dmcu only will prevent loading iram,
> it breaks backlight control.
> 
> Bug: 
> https://bugzilla.kernel.org/show_bug.cgi?id=208277 
> <https://bugzilla.kernel.org/show_bug.cgi?id=208277>
> Signed-off-by: Aaron Ma <aaron.ma@...onical.com>
> ---
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c 
> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 10ac8076d4f2..db5e0bb0d935 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -1358,7 +1358,7 @@ static int dm_late_init(void *handle)
>           struct dmcu *dmcu = NULL;
>           bool ret;
> 
> -       if (!adev->dm.fw_dmcu)
> +       if (!adev->dm.fw_dmcu && !adev->dm.dmub_fw)
>                   return detect_mst_link_for_all_connectors(adev->ddev);
> 
>           dmcu = adev->dm.dc->res_pool->dmcu;
> -- 
> 2.25.1
> 
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> 

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives