linux-kernel - Re: drivers/pinctrl/pinctrl-mcp23s08_spi.c:129:1-3: WARNING: PTR_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHp75VfpC6rX41dts3KeyMLPh8QD3ojEH6Moyu-1naE-_cfrFg@mail.gmail.com>
Date:   Thu, 9 Jul 2020 23:02:28 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     kernel test robot <lkp@...el.com>
Cc:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        kbuild-all@...ts.01.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: drivers/pinctrl/pinctrl-mcp23s08_spi.c:129:1-3: WARNING:
 PTR_ERR_OR_ZERO can be used

On Thu, Jul 9, 2020 at 9:34 PM kernel test robot <lkp@...el.com> wrote:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
> head:   0bddd227f3dc55975e2b8dfa7fc6f959b062a2c7
> commit: 0f04a81784fe3ddc00cae74c517265b3ddb8825c pinctrl: mcp23s08: Split to three parts: core, I涎, SPI
> date:   3 months ago
> config: i386-randconfig-c001-20200709 (attached as .config)
> compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@...el.com>

>    128          mcp->regmap = devm_regmap_init(dev, &mcp23sxx_spi_regmap, mcp, copy);
>  > 129          if (IS_ERR(mcp->regmap))
>    130                  return PTR_ERR(mcp->regmap);
>    131
>    132          return 0;

Right.

I expect LKP to generate such patches and submit :-)

-- 
With Best Regards,
Andy Shevchenko