linux-kernel - Re: [PATCH V2 0/3] riscv: Enable LOCKDEP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Jul 2020 07:15:31 +0800
From:   Guo Ren <guoren@...nel.org>
To:     Palmer Dabbelt <palmerdabbelt@...gle.com>
Cc:     Paul Walmsley <paul.walmsley@...ive.com>,
        Anup Patel <anup@...infault.org>,
        Greentime Hu <greentime.hu@...ive.com>,
        Zong Li <zong.li@...ive.com>,
        Albert Ou <aou@...s.berkeley.edu>,
        Thomas Gleixner <tglx@...utronix.de>,
        Tycho Andersen <tycho@...ho.ws>,
        Nick Hu <nickhu@...estech.com>,
        linux-riscv <linux-riscv@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-csky@...r.kernel.org, Guo Ren <guoren@...ux.alibaba.com>
Subject: Re: [PATCH V2 0/3] riscv: Enable LOCKDEP

Thank you, Palmer

On Fri, Jul 10, 2020 at 6:06 AM Palmer Dabbelt <palmerdabbelt@...gle.com> wrote:
>
> On Sat, 27 Jun 2020 06:57:05 PDT (-0700), guoren@...nel.org wrote:
> > From: Guo Ren <guoren@...ux.alibaba.com>
> >
> > Lockdep is needed by proving the spinlocks and rwlocks. To support it,
> > we need to add TRACE_IRQFLAGS codes in kernel/entry.S. These patches
> > follow Documentation/irqflags-tracing.txt.
> >
> > Fixup 2 bugs that block the lockdep implementation.
> >
> > ---
> > Changes in v2
> >  - Remove sX regs recovery codes which are unnecessary, because
> >    callee will handle them. Thx Greentime :)
> >
> >  - Move "restore a0 - a7" to handle_syscall, but if _TIF_SYSCALL_WORK
> >    is set, "restore a1 - a7" is still duplicated. I prefer a C wrapper
> >    for syscall.
> >
> > Guo Ren (2):
> >   riscv: Fixup static_obj() fail
> >   riscv: Enable LOCKDEP_SUPPORT & fixup TRACE_IRQFLAGS_SUPPORT
> >
> > Zong Li (1):
> >   riscv: Fixup lockdep_assert_held with wrong param cpu_running
> >
> >  arch/riscv/Kconfig              |  3 +++
> >  arch/riscv/kernel/entry.S       | 33 ++++++++++++++++++++++++++++++++-
> >  arch/riscv/kernel/smpboot.c     |  1 -
> >  arch/riscv/kernel/vmlinux.lds.S |  2 +-
> >  4 files changed, 36 insertions(+), 3 deletions(-)
>
> These are on for-next.  As far as I can tell lockdep is working, but I'm just
> doing some simple boot tests.
>
> Thanks!



-- 
Best Regards
 Guo Ren

ML: https://lore.kernel.org/linux-csky/