linux-kernel - RE: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR08MB406932241B7FB3753B77B113F7640@AM6PR08MB4069.eurprd08.prod.outlook.com>
Date:   Thu, 9 Jul 2020 09:36:42 +0000
From:   Justin He <Justin.He@....com>
To:     David Hildenbrand <david@...hat.com>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Matthew Wilcox <willy@...radead.org>
CC:     Catalin Marinas <Catalin.Marinas@....com>,
        Will Deacon <will@...nel.org>, Tony Luck <tony.luck@...el.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        "x86@...nel.org" <x86@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Dave Jiang <dave.jiang@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Baoquan He <bhe@...hat.com>,
        Chuhong Yuan <hslester96@...il.com>,
        Logan Gunthorpe <logang@...tatee.com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Michal Hocko <mhocko@...e.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>,
        "linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>,
        "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Kaly Xin <Kaly.Xin@....com>
Subject: RE: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in
 arch specific directory

Hi David

> -----Original Message-----
> From: David Hildenbrand <david@...hat.com>
> Sent: Thursday, July 9, 2020 5:19 PM
> To: Mike Rapoport <rppt@...ux.ibm.com>; Matthew Wilcox
> <willy@...radead.org>
> Cc: Justin He <Justin.He@....com>; Catalin Marinas
> <Catalin.Marinas@....com>; Will Deacon <will@...nel.org>; Tony Luck
> <tony.luck@...el.com>; Fenghua Yu <fenghua.yu@...el.com>; Yoshinori Sato
> <ysato@...rs.sourceforge.jp>; Rich Felker <dalias@...c.org>; Dave Hansen
> <dave.hansen@...ux.intel.com>; Andy Lutomirski <luto@...nel.org>; Peter
> Zijlstra <peterz@...radead.org>; Thomas Gleixner <tglx@...utronix.de>;
> Ingo Molnar <mingo@...hat.com>; Borislav Petkov <bp@...en8.de>;
> x86@...nel.org; H. Peter Anvin <hpa@...or.com>; Dan Williams
> <dan.j.williams@...el.com>; Vishal Verma <vishal.l.verma@...el.com>; Dave
> Jiang <dave.jiang@...el.com>; Andrew Morton <akpm@...ux-foundation.org>;
> Baoquan He <bhe@...hat.com>; Chuhong Yuan <hslester96@...il.com>; Logan
> Gunthorpe <logang@...tatee.com>; Masahiro Yamada <masahiroy@...nel.org>;
> Michal Hocko <mhocko@...e.com>; linux-arm-kernel@...ts.infradead.org;
> linux-kernel@...r.kernel.org; linux-ia64@...r.kernel.org; linux-
> sh@...r.kernel.org; linux-nvdimm@...ts.01.org; linux-mm@...ck.org;
> Jonathan Cameron <Jonathan.Cameron@...wei.com>; Kaly Xin <Kaly.Xin@....com>
> Subject: Re: [PATCH v3 4/6] mm: don't export memory_add_physaddr_to_nid in
> arch specific directory
> 
> On 09.07.20 11:18, Mike Rapoport wrote:
> > On Thu, Jul 09, 2020 at 03:11:04AM +0100, Matthew Wilcox wrote:
> >> On Thu, Jul 09, 2020 at 10:06:27AM +0800, Jia He wrote:
> >>> After a general version of __weak memory_add_physaddr_to_nid
> implemented
> >>> and exported , it is no use exporting twice in arch directory even if
> >>> e,g, ia64/x86 have their specific version.
> >>>
> >>> This is to suppress the modpost warning:
> >>> WARNING: modpost: vmlinux: 'memory_add_physaddr_to_nid' exported twice.
> >>> Previous export was in vmlinux
> >>
> >> It's bad form to introduce a warning and then send a follow-up patch to
> >> fix the warning.  Just fold this patch into patch 1/6.
> >
> > Moreover, I think that patches 1-4 can be merged into one.
> >
> 
> +1

Okay, will update, thanks

--
Cheers,
Justin (Jia He)