linux-kernel - Re: [PATCH v3 0/3] crypto: allow users to specify acomp hardware from a desired NUMA node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200709125552.GG31057@gondor.apana.org.au>
Date:   Thu, 9 Jul 2020 22:55:52 +1000
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     Barry Song <song.bao.hua@...ilicon.com>
Cc:     davem@...emloft.net, wangzhou1@...ilicon.com,
        jonathan.cameron@...wei.com, akpm@...ux-foundation.org,
        linux-crypto@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, linuxarm@...wei.com
Subject: Re: [PATCH v3 0/3] crypto: allow users to specify acomp hardware
 from a desired NUMA node

On Sun, Jul 05, 2020 at 09:18:57PM +1200, Barry Song wrote:
> For a typical Linux server, probably there are multiple ZIP modules.
> For example, numa node0 has a compressor, numa node2 has a same module.
> Some drivers are automatically using the module near the CPU calling
> acomp_alloc.
> But it isn't necessarily correct. Just like memory allocation API like
> kmalloc and kmalloc_node. Similar optimization may be done for crypto.
> 
> -v3:
>   move to use kzalloc_node according to Herbert's comment
> -v2:
>   cleanup according to Jonathan Cameron's comment
> 
> Barry Song (3):
>   crypto: permit users to specify numa node of acomp hardware
>   crypto: hisilicon/zip - permit users to specify NUMA node
>   mm/zswap: allocate acomp on the numa node committing acomp_req[1]
> 
> [1] This patch is againest a zswap patch which has not been merged yet:
>  "[PATCH v3] mm/zswap: move to use crypto_acomp API for hardware
>  acceleration"
>  https://lkml.org/lkml/2020/6/26/95
> 
>  crypto/acompress.c                        |  8 ++++++++
>  crypto/api.c                              | 24 ++++++++++++++---------
>  crypto/internal.h                         | 23 ++++++++++++++++++----
>  drivers/crypto/hisilicon/zip/zip.h        |  2 +-
>  drivers/crypto/hisilicon/zip/zip_crypto.c |  6 +++---
>  drivers/crypto/hisilicon/zip/zip_main.c   |  5 +++--
>  include/crypto/acompress.h                | 18 +++++++++++++++++
>  include/linux/crypto.h                    |  2 ++
>  mm/zswap.c                                |  2 +-
>  9 files changed, 70 insertions(+), 20 deletions(-)

Patches 1-2 applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt