linux-kernel - Re: [PATCH v2] arm64: dts: qcom: sdm845: Add cpu OPP tables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f36df61af67245c5fe9ca4e7550b8861@codeaurora.org>
Date:   Thu, 09 Jul 2020 20:13:49 +0530
From:   Sibi Sankar <sibis@...eaurora.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Steev Klimaszewski <steev@...i.org>, viresh.kumar@...aro.org,
        sboyd@...nel.org, georgi.djakov@...aro.org, agross@...nel.org,
        robh+dt@...nel.org, linux-arm-msm@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        saravanak@...gle.com, dianders@...omium.org,
        vincent.guittot@...aro.org, amit.kucheria@...aro.org,
        robdclark@...omium.org, linux-kernel-owner@...r.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: sdm845: Add cpu OPP tables

On 2020-07-09 19:59, Bjorn Andersson wrote:
> On Wed 08 Jul 19:22 PDT 2020, Steev Klimaszewski wrote:
> 
>> 
>> On 7/2/20 3:46 PM, Sibi Sankar wrote:
>> > Add OPP tables required to scale DDR/L3 per freq-domain on SDM845 SoCs.
>> >
>> > Signed-off-by: Sibi Sankar <sibis@...eaurora.org>
>> > ---
>> 
>> 
>> Hi Sibi,
>> 
>> 
>> Bjorn asked me to give this patch a whirl, and I have to say, I like 
>> it
>> but I'm not sure if I'm missing a dependency somewhere...
>> 
>> 
>> In 5.8.0-rc4, I'm seeing a couple probe defers
>> 
>> [    0.131341] cpu cpu0: _allocate_opp_table: Error finding 
>> interconnect
>> paths: -517
>> 
>> [    0.132694] cpu cpu4: _allocate_opp_table: Error finding 
>> interconnect
>> paths: -517
>> 
>> And then a bit later on,
>> 
>> [    0.625837] cpu cpu0: failed to get clock: -2
>> 
>> 
>> If these aren't anything to worry about, you can throw my Tested-by on
>> 
>> Tested-by: Steev Klimaszewski <steev@...i.org>
>> 
> 
> You need to enable:
> CONFIG_INTERCONNECT=y
> CONFIG_INTERCONNECT_QCOM=y
> CONFIG_INTERCONNECT_QCOM_OSM_L3=m
> CONFIG_INTERCONNECT_QCOM_SDM845=m

Steev had ^^ enabled but he was missing
the required cpufreq driver changes
available in linux-next.

> 
> With this I can see the interconnect_summary in debugfs change with the
> CPU frequency.
> 
> Regards,
> Bjorn

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.