linux-kernel - Re: [PATCH] thermal/int340x_thermal: Prevent page fault on .set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e4e13cdad78f8593b5c307b5130e416bdc1dccbf.camel@linux.intel.com>
Date:   Thu, 09 Jul 2020 10:00:43 -0700
From:   Srinivas Pandruvada <srinivas.pandruvada@...ux.intel.com>
To:     Bartosz Szczepanek <bsz@...ihalf.com>,
        Matthew Garrett <mjg59@...gle.com>,
        Zhang Rui <rui.zhang@...el.com>, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Daniel Lezcano <daniel.lezcano@...aro.org>,
        Amit Kucheria <amit.kucheria@...durent.com>,
        Radoslaw Biernacki <rad@...ihalf.com>,
        Alex Levin <levinale@...gle.com>
Subject: Re: [PATCH] thermal/int340x_thermal: Prevent page fault on
 .set_mode() op

On Wed, 2020-07-08 at 15:46 +0200, Bartosz Szczepanek wrote:
> Starting from commit "thermal/int340x_thermal: Don't require IDSP to
> exist", priv->current_uuid_index is initialized to -1. This value may
> be passed to int3400_thermal_run_osc() from int3400_thermal_set_mode,
> contributing to page fault when accessing int3400_thermal_uuids array
> at index -1.
> 
> This commit adds a check on uuid value to int3400_thermal_run_osc.
> 
> Signed-off-by: Bartosz Szczepanek <bsz@...ihalf.com>
Reviewed-by: Pandruvada, Srinivas <srinivas.pandruvada@...ux.intel.com>

> ---
>  drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> index 0b3a62655843..12448ccd27f1 100644
> --- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> +++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> @@ -216,11 +216,16 @@ static int int3400_thermal_run_osc(acpi_handle
> handle,
>  	acpi_status status;
>  	int result = 0;
>  	struct acpi_osc_context context = {
> -		.uuid_str = int3400_thermal_uuids[uuid],
> +		.uuid_str = NULL,
>  		.rev = 1,
>  		.cap.length = 8,
>  	};
>  
> +	if (uuid < 0 || uuid >= INT3400_THERMAL_MAXIMUM_UUID)
> +		return -EINVAL;
> +
> +	context.uuid_str = int3400_thermal_uuids[uuid];
> +
>  	buf[OSC_QUERY_DWORD] = 0;
>  	buf[OSC_SUPPORT_DWORD] = enable;
>