linux-kernel - Re: [PATCH] bcache: writeback: Remove unneeded variable ret

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e50bf828-997d-38e7-76c4-fd3a70ab6c36@suse.de>
Date:   Thu, 9 Jul 2020 12:07:37 +0800
From:   Coly Li <colyli@...e.de>
To:     Xu Wang <vulab@...as.ac.cn>
Cc:     kent.overstreet@...il.com, linux-bcache@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] bcache: writeback: Remove unneeded variable ret

On 2020/7/9 11:39, Xu Wang wrote:
> Remove unneeded variable ret i.
> 

I see 'i' is removed, where is 'ret' ?

Thanks.


Coly Li


> Signed-off-by: Xu Wang <vulab@...as.ac.cn>
> ---
>  drivers/md/bcache/writeback.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/md/bcache/writeback.c b/drivers/md/bcache/writeback.c
> index 1cf1e5016cb9..71801c086b82 100644
> --- a/drivers/md/bcache/writeback.c
> +++ b/drivers/md/bcache/writeback.c
> @@ -825,10 +825,8 @@ static int bch_dirty_init_thread(void *arg)
>  	struct btree_iter iter;
>  	struct bkey *k, *p;
>  	int cur_idx, prev_idx, skip_nr;
> -	int i;
>  
>  	k = p = NULL;
> -	i = 0;
>  	cur_idx = prev_idx = 0;
>  
>  	bch_btree_iter_init(&c->root->keys, &iter, NULL);
>