linux-kernel - Re: [PATCH] MAINTAINERS: XDP: restrict N: and K:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tuyfi4fm.fsf@toke.dk>
Date:   Fri, 10 Jul 2020 20:57:17 +0200
From:   Toke Høiland-Jørgensen <toke@...hat.com>
To:     Joe Perches <joe@...ches.com>,
        "Alexander A. Klimov" <grandmaster@...klimov.de>,
        Daniel Borkmann <daniel@...earbox.net>, ast@...nel.org,
        davem@...emloft.net, kuba@...nel.org, hawk@...nel.org,
        john.fastabend@...il.com, mchehab+huawei@...nel.org,
        robh@...nel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH] MAINTAINERS: XDP: restrict N: and K:

Joe Perches <joe@...ches.com> writes:

> On Fri, 2020-07-10 at 20:18 +0200, Alexander A. Klimov wrote:
>> 
>> Am 10.07.20 um 18:12 schrieb Toke Høiland-Jørgensen:
>> > Joe Perches <joe@...ches.com> writes:
>> > 
>> > > On Fri, 2020-07-10 at 17:14 +0200, Daniel Borkmann wrote:
>> > > > On 7/10/20 8:17 AM, Alexander A. Klimov wrote:
>> > > > > Am 09.07.20 um 22:37 schrieb Daniel Borkmann:
>> > > > > > On 7/9/20 9:42 PM, Alexander A. Klimov wrote:
>> > > > > > > Rationale:
>> > > > > > > Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
>> > > > > > > which has nothing to do with XDP.
>> > > []
>> > > > > > > diff --git a/MAINTAINERS b/MAINTAINERS
>> > > []
>> > > > > > > @@ -18708,8 +18708,8 @@ F:    include/trace/events/xdp.h
>> > > > > > >    F:    kernel/bpf/cpumap.c
>> > > > > > >    F:    kernel/bpf/devmap.c
>> > > > > > >    F:    net/core/xdp.c
>> > > > > > > -N:    xdp
>> > > > > > > -K:    xdp
>> > > > > > > +N:    (?:\b|_)xdp(?:\b|_)
>> > > > > > > +K:    (?:\b|_)xdp(?:\b|_)
>> > > > > > 
>> > > > > > Please also include \W to generally match on non-alphanumeric char given you
>> > > > > > explicitly want to avoid [a-z0-9] around the term xdp.
>> > > > > Aren't \W, ^ and $ already covered by \b?
>> > > > 
>> > > > Ah, true; it says '\b really means (?:(?<=\w)(?!\w)|(?<!\w)(?=\w))', so all good.
>> > > > In case this goes via net or net-next tree:
>> > > 
>> > > This N: pattern does not match files like:
>> > > 
>> > > 	samples/bpf/xdp1_kern.c
>> > > 
>> > > and does match files like:
>> > > 
>> > > 	drivers/net/ethernet/broadcom/bnxt/bnxt_xdp.c
>> > > 
>> > > Should it?
>> > 
>> > I think the idea is that it should match both?
>> In *your* opinion: Which of these shall it (not) match?
>
> Dunno, but it doesn't match these files.
> The first 5 are good, the rest probably should.

Yup, I agree, all but the first 5 should be matched...

-Toke

> $ git ls-files | grep xdp | grep -v -P '(?:\b|_)xdp(?:\b|_)'
> Documentation/hwmon/xdpe12284.rst
> arch/arm/mach-ixp4xx/ixdp425-pci.c
> arch/arm/mach-ixp4xx/ixdp425-setup.c
> arch/arm/mach-ixp4xx/ixdpg425-pci.c
> drivers/hwmon/pmbus/xdpe12284.c
> samples/bpf/xdp1_kern.c
> samples/bpf/xdp1_user.c
> samples/bpf/xdp2_kern.c
> samples/bpf/xdp2skb_meta.sh
> samples/bpf/xdp2skb_meta_kern.c
> samples/bpf/xdpsock.h
> samples/bpf/xdpsock_kern.c
> samples/bpf/xdpsock_user.c
> tools/testing/selftests/bpf/progs/xdping_kern.c
> tools/testing/selftests/bpf/test_xdping.sh
> tools/testing/selftests/bpf/xdping.c
> tools/testing/selftests/bpf/xdping.h