[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200710135844.58d76d44@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date: Fri, 10 Jul 2020 13:58:44 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: <min.li.xe@...esas.com>
Cc: <richardcochran@...il.com>, <netdev@...r.kernel.org>,
<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next] ptp: add debugfs support for IDT family of
timing devices
On Fri, 10 Jul 2020 11:41:25 -0400 min.li.xe@...esas.com wrote:
> From: Min Li <min.li.xe@...esas.com>
>
> This patch is to add debugfs support for ptp_clockmatrix and ptp_idt82p33.
> It will create a debugfs directory called idtptp{x} and x is the ptp index.
> Three inerfaces are present, which are cmd, help and regs. help is read
> only and will display a brief help message. regs is read only amd will show
> all register values. cmd is write only and will accept certain commands.
> Currently, the accepted commands are combomode to set comobo mode and write
> to write up to 4 registers.
>
> Signed-off-by: Min Li <min.li.xe@...esas.com>
No private configuration interfaces in debugfs, please.
If what you're exposing is a useful feature it deserves a proper
uAPI interface.
Powered by blists - more mailing lists