| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <d9875eae-d7e5-e091-4f3d-b279157ac1c1@codeaurora.org>
Date: Sat, 11 Jul 2020 04:06:41 +0530
From: Akhil P Oommen <akhilpo@...eaurora.org>
To: Jonathan Marek <jonathan@...ek.ca>, freedreno@...ts.freedesktop.org
Cc: devicetree@...r.kernel.org, saravanak@...gle.com,
linux-arm-msm@...r.kernel.org, smasetty@...eaurora.org,
linux-kernel@...r.kernel.org, mka@...omium.org,
dri-devel@...edesktop.org, viresh.kumar@...aro.org,
sibis@...eaurora.org
Subject: Re: [PATCH v4 3/7] drm: msm: a6xx: set gpu freq through hfi
On 7/11/2020 2:43 AM, Akhil P Oommen wrote:
>
> On 7/10/2020 1:34 AM, Jonathan Marek wrote:
>> On 7/9/20 4:00 PM, Akhil P Oommen wrote:
>>> Newer targets support changing gpu frequency through HFI. So
>>> use that wherever supported instead of the legacy method.
>>>
>>
>> It was already using HFI on newer targets. Don't break it in one
>> commit then fix it in the next.
>
> Oops. I somehow got confused. Will fix and resend.
>
> -Akhil
I broke the pm_runtime_get_if_in_use() check too. Other than that, just
squashing this patch with the previous one should be enough.
-Akhil.
>
>>
>>> Signed-off-by: Akhil P Oommen <akhilpo@...eaurora.org>
>>> ---
>>> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 11 +++++++----
>>> 1 file changed, 7 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
>>> b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
>>> index 233afea..b547339 100644
>>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
>>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c
>>> @@ -121,6 +121,12 @@ void a6xx_gmu_set_freq(struct msm_gpu *gpu,
>>> struct dev_pm_opp *opp)
>>> if (gpu_freq == gmu->gpu_freqs[perf_index])
>>> break;
>>> + if (!gmu->legacy) {
>>> + a6xx_hfi_set_freq(gmu, gmu->current_perf_index);
>>> + icc_set_bw(gpu->icc_path, 0, MBps_to_icc(7216));
>>> + return;
>>> + }
>>> +
>>> gmu->current_perf_index = perf_index;
>>> gmu->freq = gmu->gpu_freqs[perf_index];
>>> @@ -893,10 +899,7 @@ int a6xx_gmu_resume(struct a6xx_gpu *a6xx_gpu)
>>> enable_irq(gmu->hfi_irq);
>>> /* Set the GPU to the current freq */
>>> - if (gmu->legacy)
>>> - a6xx_gmu_set_initial_freq(gpu, gmu);
>>> - else
>>> - a6xx_hfi_set_freq(gmu, gmu->current_perf_index);
>>> + a6xx_gmu_set_initial_freq(gpu, gmu);
>>> /*
>>> * "enable" the GX power domain which won't actually do
>>> anything but it
>>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@...ts.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
> _______________________________________________
> dri-devel mailing list
> dri-devel@...ts.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Powered by blists - more mailing lists