linux-kernel - RE: [PATCH v4 0/2] Fix and enable pmem as RAM device on arm64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Jul 2020 13:13:51 +0000
From:   Justin He <Justin.He@....com>
To:     David Hildenbrand <david@...hat.com>,
        Catalin Marinas <Catalin.Marinas@....com>,
        Will Deacon <will@...nel.org>, Tony Luck <tony.luck@...el.com>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>
CC:     "x86@...nel.org" <x86@...nel.org>,
        "H. Peter Anvin" <hpa@...or.com>,
        Dan Williams <dan.j.williams@...el.com>,
        Vishal Verma <vishal.l.verma@...el.com>,
        Dave Jiang <dave.jiang@...el.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Baoquan He <bhe@...hat.com>,
        Chuhong Yuan <hslester96@...il.com>,
        Mike Rapoport <rppt@...ux.ibm.com>,
        Logan Gunthorpe <logang@...tatee.com>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Michal Hocko <mhocko@...e.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-ia64@...r.kernel.org" <linux-ia64@...r.kernel.org>,
        "linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>,
        "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        Jonathan Cameron <Jonathan.Cameron@...wei.com>,
        Kaly Xin <Kaly.Xin@....com>
Subject: RE: [PATCH v4 0/2] Fix and enable pmem as RAM device on arm64


Hi David
> -----Original Message-----
> From: David Hildenbrand <david@...hat.com>
> Sent: Friday, July 10, 2020 4:30 PM
> To: Justin He <Justin.He@....com>; Catalin Marinas
> <Catalin.Marinas@....com>; Will Deacon <will@...nel.org>; Tony Luck
> <tony.luck@...el.com>; Fenghua Yu <fenghua.yu@...el.com>; Yoshinori Sato
> <ysato@...rs.sourceforge.jp>; Rich Felker <dalias@...c.org>; Dave Hansen
> <dave.hansen@...ux.intel.com>; Andy Lutomirski <luto@...nel.org>; Peter
> Zijlstra <peterz@...radead.org>; Thomas Gleixner <tglx@...utronix.de>;
> Ingo Molnar <mingo@...hat.com>; Borislav Petkov <bp@...en8.de>
> Cc: x86@...nel.org; H. Peter Anvin <hpa@...or.com>; Dan Williams
> <dan.j.williams@...el.com>; Vishal Verma <vishal.l.verma@...el.com>; Dave
> Jiang <dave.jiang@...el.com>; Andrew Morton <akpm@...ux-foundation.org>;
> Baoquan He <bhe@...hat.com>; Chuhong Yuan <hslester96@...il.com>; Mike
> Rapoport <rppt@...ux.ibm.com>; Logan Gunthorpe <logang@...tatee.com>;
> Masahiro Yamada <masahiroy@...nel.org>; Michal Hocko <mhocko@...e.com>;
> linux-arm-kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; linux-
> ia64@...r.kernel.org; linux-sh@...r.kernel.org; linux-nvdimm@...ts.01.org;
> linux-mm@...ck.org; Jonathan Cameron <Jonathan.Cameron@...wei.com>; Kaly
> Xin <Kaly.Xin@....com>
> Subject: Re: [PATCH v4 0/2] Fix and enable pmem as RAM device on arm64
> 
> On 10.07.20 05:16, Jia He wrote:
> > This fixies a few issues when I tried to enable pmem as RAM device on
> arm64.
> >
> > To use memory_add_physaddr_to_nid as a fallback nid, it would be better
> > implement a general version (__weak) in mm/memory_hotplug. After that,
> arm64/
> > sh/s390 can simply use the general version, and PowerPC/ia64/x86 will
> use
> > arch specific version.
> >
> > Tested on ThunderX2 host/qemu "-M virt" guest with a nvdimm device. The
> > memblocks from the dax pmem device can be either hot-added or hot-
> removed
> > on arm64 guest. Also passed the compilation test on x86.
> >
> > Changes:
> > v4: - remove "device-dax: use fallback nid when numa_node is invalid",
> wait
> >       for Dan Williams' phys_addr_to_target_node() patch
> 
> So, this series no longer does what it promises? "Fix and enable pmem as
> RAM device on arm64"
> 
Hmm, a little bit awkward but seems no long what it promises. How about
sending patch1 patch2 individually without this cover-letter?

--
Cheers,
Justin (Jia He)