linux-kernel - Re: [PATCH v5 6/6] PCI: uniphier: Use devm_platform_ioremap_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200710132950.GA5540@e121166-lin.cambridge.arm.com>
Date:   Fri, 10 Jul 2020 14:29:50 +0100
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>
Cc:     Bjorn Helgaas <bhelgaas@...gle.com>,
        Jingoo Han <jingoohan1@...il.com>,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        Rob Herring <robh+dt@...nel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Marc Zyngier <maz@...nel.org>, linux-pci@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org,
        Masami Hiramatsu <masami.hiramatsu@...aro.org>,
        Jassi Brar <jaswinder.singh@...aro.org>
Subject: Re: [PATCH v5 6/6] PCI: uniphier: Use
 devm_platform_ioremap_resource_byname()

On Fri, Jul 10, 2020 at 09:54:12AM +0900, Kunihiko Hayashi wrote:
> Hi Lorenzo,
> 
> This 6/6 patch has just been covered with the following patch:
> https://patchwork.ozlabs.org/project/linux-pci/patch/20200708164013.5076-1-zhengdejin5@gmail.com/
> 
> As a result, my other patches conflict with this patch.
> I'd like your comments in the patch 2/6, though,
> should I rebase to pci/dwc and resend this series without 6/6?

No, don't worry about patch (6). I will review patch (2) shortly.

Thanks,
Lorenzo

> Thank you,
> 
> On 2020/06/18 17:38, Kunihiko Hayashi wrote:
> > Use devm_platform_ioremap_resource_byname() to simplify the code a bit.
> > 
> > Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>f
> > ---
> >   drivers/pci/controller/dwc/pcie-uniphier.c | 3 +--
> >   1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/pci/controller/dwc/pcie-uniphier.c b/drivers/pci/controller/dwc/pcie-uniphier.c
> > index 8356dd3..233d624 100644
> > --- a/drivers/pci/controller/dwc/pcie-uniphier.c
> > +++ b/drivers/pci/controller/dwc/pcie-uniphier.c
> > @@ -456,8 +456,7 @@ static int uniphier_pcie_probe(struct platform_device *pdev)
> >   	if (IS_ERR(priv->pci.atu_base))
> >   		priv->pci.atu_base = NULL;
> > -	res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "link");
> > -	priv->base = devm_ioremap_resource(dev, res);
> > +	priv->base = devm_platform_ioremap_resource_byname(pdev, "link");
> >   	if (IS_ERR(priv->base))
> >   		return PTR_ERR(priv->base);
> > 
> 
> ---
> Best Regards
> Kunihiko Hayashi