linux-kernel - Re: [PATCH v4] mm/hugetlb: avoid hardcoding while checking if cma is enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f8f2a080-4bfe-8e3f-02bd-6fc5c9c59574@oracle.com>
Date:   Thu, 9 Jul 2020 20:11:38 -0700
From:   Mike Kravetz <mike.kravetz@...cle.com>
To:     Barry Song <song.bao.hua@...ilicon.com>, akpm@...ux-foundation.org
Cc:     linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        linuxarm@...wei.com,
        Jonathan Cameron <jonathan.cameron@...wei.com>,
        Roman Gushchin <guro@...com>
Subject: Re: [PATCH v4] mm/hugetlb: avoid hardcoding while checking if cma is
 enabled

On 7/9/20 5:57 PM, Barry Song wrote:
> hugetlb_cma[0] can be NULL due to various reasons, for example, node0 has
> no memory. so NULL hugetlb_cma[0] doesn't necessarily mean cma is not
> enabled. gigantic pages might have been reserved on other nodes.
> This patch fixes possible double reservation and CMA leak.
> 
> Fixes: cf11e85fc08c ("mm: hugetlb: optionally allocate gigantic hugepages using cma")
> Cc: Mike Kravetz <mike.kravetz@...cle.com>
> Cc: Jonathan Cameron <jonathan.cameron@...wei.com>
> Acked-by: Roman Gushchin <guro@...com>
> Signed-off-by: Barry Song <song.bao.hua@...ilicon.com>

Thank you!

Reviewed-by: Mike Kravetz <mike.kravetz@...cle.com>

-- 
Mike Kravetz