[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d3d239df-cbd3-e495-a3c2-af3407bfaf73@wanyeetech.com>
Date: Fri, 10 Jul 2020 21:57:10 +0800
From: Zhou Yanjie <zhouyanjie@...yeetech.com>
To: Rob Herring <robh@...nel.org>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
tglx@...utronix.de, daniel.lezcano@...aro.org,
paul@...pouillou.net, dongsheng.qiu@...enic.com,
aric.pzqi@...enic.com, rick.tyliu@...enic.com,
yanfei.li@...enic.com, sernia.zhou@...mail.com,
zhenwenjin@...il.com
Subject: Re: [PATCH v5 1/2] dt-bindings: timer: Add Ingenic X1000 OST
bindings.
Hi Rob,
在 2020/7/10 上午6:49, Rob Herring 写道:
> On Sun, Jul 05, 2020 at 10:03:52PM +0800, 周琰杰 (Zhou Yanjie) wrote:
>> Add the OST bindings for the X10000 SoC from Ingenic.
>>
>> Tested-by: 周正 (Zhou Zheng) <sernia.zhou@...mail.com>
>> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com>
>> Reviewed-by: Paul Cercueil <paul@...pouillou.net>
>> ---
>>
>> Notes:
>> v1->v2:
>> No change.
>>
>> v2->v3:
>> Fix wrong parameters in "clocks".
>>
>> v3->v4:
>> 1.Rename "ingenic,ost.yaml" to "ingenic,sysost.yaml".
>> 2.Rename "ingenic,ost.h" to "ingenic,sysost.h".
>> 3.Modify the description in "ingenic,sysost.yaml".
>>
>> v4->v5:
>> No change.
>>
>> .../devicetree/bindings/timer/ingenic,sysost.yaml | 60 ++++++++++++++++++++++
>> include/dt-bindings/clock/ingenic,sysost.h | 12 +++++
>> 2 files changed, 72 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/timer/ingenic,sysost.yaml
>> create mode 100644 include/dt-bindings/clock/ingenic,sysost.h
>>
>> diff --git a/Documentation/devicetree/bindings/timer/ingenic,sysost.yaml b/Documentation/devicetree/bindings/timer/ingenic,sysost.yaml
>> new file mode 100644
>> index 000000000000..03257ed806fc
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/timer/ingenic,sysost.yaml
>> @@ -0,0 +1,60 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/timer/ingenic,sysost.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Bindings for SYSOST in Ingenic XBurst family SoCs
>> +
>> +maintainers:
>> + - 周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com>
>> +
>> +description:
>> + The SYSOST in an Ingenic SoC provides one 64bit timer for clocksource
>> + and one or more 32bit timers for clockevent.
>> +
>> +properties:
>> + compatible:
>> + oneOf:
>> +
>> + - enum:
> Only 1 entry, drop 'oneOf' and the blank line.
Sure.
>> + - ingenic,x1000-ost
>> + - ingenic,x2000-ost
>> +
>> + reg:
>> + maxItems: 1
>> +
>> + clocks:
>> + maxItems: 1
>> +
>> + clock-names:
>> + const: ost
>> +
>> + interrupts:
>> + maxItems: 1
>> +
>> +required:
>> + - "#clock-cells"
>> + - compatible
>> + - reg
>> + - clocks
>> + - clock-names
>> + - interrupts
> additionalProperties: false
Sure.
Thanks and best regards!
>> +
>> +examples:
>> + - |
>> + #include <dt-bindings/clock/x1000-cgu.h>
>> +
>> + ost: timer@...00000 {
>> + compatible = "ingenic,x1000-ost";
>> + reg = <0x12000000 0x3c>;
>> +
>> + #clock-cells = <1>;
>> +
>> + clocks = <&cgu X1000_CLK_OST>;
>> + clock-names = "ost";
>> +
>> + interrupt-parent = <&cpuintc>;
>> + interrupts = <3>;
>> + };
>> +...
>> diff --git a/include/dt-bindings/clock/ingenic,sysost.h b/include/dt-bindings/clock/ingenic,sysost.h
>> new file mode 100644
>> index 000000000000..9ac88e90babf
>> --- /dev/null
>> +++ b/include/dt-bindings/clock/ingenic,sysost.h
>> @@ -0,0 +1,12 @@
>> +/* SPDX-License-Identifier: GPL-2.0 */
>> +/*
>> + * This header provides clock numbers for the ingenic,tcu DT binding.
>> + */
>> +
>> +#ifndef __DT_BINDINGS_CLOCK_INGENIC_OST_H__
>> +#define __DT_BINDINGS_CLOCK_INGENIC_OST_H__
>> +
>> +#define OST_CLK_PERCPU_TIMER 0
>> +#define OST_CLK_GLOBAL_TIMER 1
>> +
>> +#endif /* __DT_BINDINGS_CLOCK_INGENIC_OST_H__ */
>> --
>> 2.11.0
>>
Powered by blists - more mailing lists