linux-kernel - Re: [PATCH] blk-mq: Remove unnecessary validation before calling blk_mq_sched_completed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eddd681b-6a80-486d-3655-e8810ba7b118@kernel.dk>
Date:   Fri, 10 Jul 2020 08:00:14 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Baolin Wang <baolin.wang@...ux.alibaba.com>
Cc:     ming.lei@...hat.com, baolin.wang7@...il.com,
        linux-block@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] blk-mq: Remove unnecessary validation before calling
 blk_mq_sched_completed_request()

On 7/4/20 1:28 AM, Baolin Wang wrote:
> We've already validated the 'q->elevator' before calling ->ops.completed_request()
> in blk_mq_sched_completed_request(), thus no need to validate rq->internal_tag again,
> and remove it.

Applied, but I reformatted and edited your commit message.

-- 
Jens Axboe