linux-kernel - Re: [PATCH v3] vmalloc: Add the right hint when vmalloc failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200710140439.GA14846@pc636>
Date:   Fri, 10 Jul 2020 16:04:39 +0200
From:   Uladzislau Rezki <urezki@...il.com>
To:     Matthew Wilcox <willy@...radead.org>
Cc:     Uladzislau Rezki <urezki@...il.com>,
        Tian Tao <tiantao6@...ilicon.com>, akpm@...ux-foundation.org,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        linuxarm@...wei.com
Subject: Re: [PATCH v3] vmalloc: Add the right hint when vmalloc failed

On Fri, Jul 10, 2020 at 02:53:01PM +0100, Matthew Wilcox wrote:
> On Fri, Jul 10, 2020 at 03:49:56PM +0200, Uladzislau Rezki wrote:
> > > On Fri, Jul 10, 2020 at 08:17:52PM +0800, Tian Tao wrote:
> > > > In fact "vmalloc=<size>" cmdline option is not available on many
> > > > platforms.When the user encounters this error, add the correct
> > > > hint to prevent misleading.
> > > 
> > > i don't think this is an improvement.
> > >
> > Matthew, maybe it should not be considered as improvements?
> 
> Every patch should be an improvement along some dimension.  This doesn't
> feel like an improvement in any way.
> 
> > It is rather an extra information that indicates that your
> > ARCH may not support "vmalloc" early parameter.
> 
> If anything needs to be improved, it's the documentation, not this
> error message.
>
As i mentioned before, i do not have a strong opinion about this
patch. From the other hand improving that message looks normal
to me. Especially in a context that it took a time to understand
that ARM64 does not support it, so we have had a precedent. I am
talking about author of this patch.

--
Vlad Rezki