linux-kernel - Re: [PATCH v1] regmap: Switch to use fwnode instead of OF one

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200710143529.GR3703480@smile.fi.intel.com>
Date:   Fri, 10 Jul 2020 17:35:29 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH v1] regmap: Switch to use fwnode instead of OF one

On Fri, Jul 10, 2020 at 05:15:27PM +0300, Andy Shevchenko wrote:
> On Fri, Jul 10, 2020 at 5:13 PM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> >
> > On Fri, Jul 10, 2020 at 4:36 PM Mark Brown <broonie@...nel.org> wrote:
> > >
> > > On Fri, Jul 10, 2020 at 01:08:56PM +0100, Mark Brown wrote:
> > > > On Fri, Jul 10, 2020 at 02:46:22PM +0300, Andy Shevchenko wrote:
> > >
> > > > > You mean it's being synchronised with git.kernel.org, but not yet contains that
> > > > > patch? Okay, I will monitor the regmap tree (as of now I didn't see any update).
> > >
> > > > 5cc2013bfeee756a1ee6da9bfbe42e52b4695035
> > >
> > > Oh, I see your patch covered a different bit of code without covering
> > > the stuff in regmap-irq (which I'd just handled when your patch came in)
> > > for some reason so the changelog made it sound like the same code, and
> > > at the time you submitted it the patch was incomplete.
> >
> > Should I do anything to improve it?
> 
> Actually I think we can completely get rid of fwnode by switching to
> device properties.
> I'll send v2 soon.

Oops, I have looked into this and see that either way we would need an
additional conditional and fwnode approach looks better. So, if you agree with
v1, please apply.

-- 
With Best Regards,
Andy Shevchenko