linux-kernel - Re: [PATCH v2] MAINTAINERS: XDP: restrict N: and K:

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200711102318.28ce29d6@carbon>
Date:   Sat, 11 Jul 2020 10:23:18 +0200
From:   Jesper Dangaard Brouer <brouer@...hat.com>
To:     Joe Perches <joe@...ches.com>
Cc:     brouer@...hat.com,
        "Alexander A. Klimov" <grandmaster@...klimov.de>, ast@...nel.org,
        daniel@...earbox.net, davem@...emloft.net, kuba@...nel.org,
        hawk@...nel.org, john.fastabend@...il.com,
        mchehab+huawei@...nel.org, robh@...nel.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        bpf@...r.kernel.org
Subject: Re: [PATCH v2] MAINTAINERS: XDP: restrict N: and K:

On Fri, 10 Jul 2020 12:37:47 -0700
Joe Perches <joe@...ches.com> wrote:

> On Fri, 2020-07-10 at 21:04 +0200, Alexander A. Klimov wrote:
> > Rationale:
> > Documentation/arm/ixp4xx.rst contains "xdp" as part of "ixdp465"
> > which has nothing to do with XDP.
> > 
> > Signed-off-by: Alexander A. Klimov <grandmaster@...klimov.de>
> > ---
> >  Better?
> > 
> >  MAINTAINERS | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 1d4aa7f942de..735e2475e926 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -18708,8 +18708,8 @@ F:	include/trace/events/xdp.h
> >  F:	kernel/bpf/cpumap.c
> >  F:	kernel/bpf/devmap.c
> >  F:	net/core/xdp.c
> > -N:	xdp
> > -K:	xdp
> > +N:	(?:\b|_)xdp
> > +K:	(?:\b|_)xdp  
> 
> Generally, it's better to have comprehensive files lists
> rather than adding name matching regexes.

I like below more direct matching of the files we already know are XDP
related. The pattern match are meant to catch drivers containing XDP
related bits.

(small typo in your patch below)

> Perhaps:
> ---
>  MAINTAINERS | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 16854e47e8cb..2e96cbf15b31 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -18763,13 +18763,19 @@ M:	John Fastabend <john.fastabend@...il.com>
>  L:	netdev@...r.kernel.org
>  L:	bpf@...r.kernel.org
>  S:	Supported
> -F:	include/net/xdp.h
> +F:	Documentation/networking/af_xdp.rst
> +F:	include/net/xdp*
>  F:	include/trace/events/xdp.h
> +F:	include/uapi/linux/if_xdp.h
> +F:	include/uapi/linux/xdp_diag.h
>  F:	kernel/bpf/cpumap.c
>  F:	kernel/bpf/devmap.c
>  F:	net/core/xdp.c
> -N:	xdp
> -K:	xdp
> +F:	net/xdp/
> +F:	samples/bpf/xdp*
> +F:	tools/testing/selftests/bfp/*xdp*
                               ^^^^ 
Typo, should be "bpf"

> +F:	tools/testing/selftests/bfp/*/*xdp*
> +K:	(?:\b|_)xdp(?:\b|_)
>  
>  XDP SOCKETS (AF_XDP)
>  M:	Björn Töpel <bjorn.topel@...el.com>
> 



-- 
Best regards,
  Jesper Dangaard Brouer
  MSc.CS, Principal Kernel Engineer at Red Hat
  LinkedIn: http://www.linkedin.com/in/brouer