linux-kernel - Re: [PATCH v6 08/17] static_call: Avoid kprobes on inline static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200711103053.GD597537@hirez.programming.kicks-ass.net>
Date:   Sat, 11 Jul 2020 12:30:53 +0200
From:   Peter Zijlstra <peterz@...radead.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     mhiramat@...nel.org, x86@...nel.org, linux-kernel@...r.kernel.org,
        bristot@...hat.com, jbaron@...mai.com,
        torvalds@...ux-foundation.org, tglx@...utronix.de,
        mingo@...nel.org, namit@...are.com, hpa@...or.com, luto@...nel.org,
        ard.biesheuvel@...aro.org, jpoimboe@...hat.com,
        pbonzini@...hat.com, mathieu.desnoyers@...icios.com,
        linux@...musvillemoes.dk
Subject: Re: [PATCH v6 08/17] static_call: Avoid kprobes on inline
 static_call()s

On Fri, Jul 10, 2020 at 06:00:14PM -0400, Steven Rostedt wrote:

> > +int static_call_text_reserved(void *start, void *end)
> > +{
> > +	int ret = __static_call_text_reserved(__start_static_call_sites,
> > +			__stop_static_call_sites, start, end);
> > +
> > +	if (ret)
> > +		return ret;
> > +
> > +#ifdef CONFIG_MODULES
> > +	ret = __static_call_mod_text_reserved(start, end);
> > +#endif
> 
> Nit, but why not have a #else /* !CONFIG_MODULE */ above and just:
> 
> static inline int __static_call_mod_text_reserve(..)
> {
> 	return 0;
> }
> #endif
> 
> ?

Done.