[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20200711194156.GA1218486@builder.lan>
Date: Sat, 11 Jul 2020 12:41:56 -0700
From: Bjorn Andersson <bjorn.andersson@...aro.org>
To: Randy Dunlap <rdunlap@...radead.org>
Cc: Rob Herring <robh+dt@...nel.org>,
LKML <linux-kernel@...r.kernel.org>,
"linux-next@...r.kernel.org" <linux-next@...r.kernel.org>,
Frank Rowand <frowand.list@...il.com>,
devicetree@...r.kernel.org, Andy Gross <agross@...nel.org>,
linux-arm-msm <linux-arm-msm@...r.kernel.org>,
Akash Asthana <akashast@...eaurora.org>
Subject: Re: [PATCH -next] <linux/of.h>: add stub for of_get_next_parent() to
fix qcom build error
On Fri 10 Jul 16:40 PDT 2020, Randy Dunlap wrote:
> On 7/10/20 8:28 AM, Rob Herring wrote:
> > On Mon, Jun 29, 2020 at 10:43 AM Randy Dunlap <rdunlap@...radead.org> wrote:
> >>
> >> From: Randy Dunlap <rdunlap@...radead.org>
> >>
> >> Fix a (COMPILE_TEST) build error when CONFIG_OF is not set/enabled
> >> by adding a stub for of_get_next_parent().
> >>
> >> ../drivers/soc/qcom/qcom-geni-se.c:819:11: error: implicit declaration of function 'of_get_next_parent'; did you mean 'of_get_parent'? [-Werror=implicit-function-declaration]
> >> ../drivers/soc/qcom/qcom-geni-se.c:819:9: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
> >>
> >
> > Fixes tag?
>
> Are linux-next hashes/tags stable?
>
Yes, the hashes of the Qualcomm tree are stable.
> Fixes: 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to fix earlycon crash")
>
Thank you, added this to the commit and...
> >> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> >> Cc: Rob Herring <robh+dt@...nel.org>
> >> Cc: Frank Rowand <frowand.list@...il.com>
> >> Cc: devicetree@...r.kernel.org
> >> Cc: Andy Gross <agross@...nel.org>
> >> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> >> Cc: linux-arm-msm@...r.kernel.org
> >> ---
> >> include/linux/of.h | 5 +++++
> >> 1 file changed, 5 insertions(+)
> >
> > I'm assuming this will be applied to the tree that introduced the problem.
> >
> > Acked-by: Rob Herring <robh@...nel.org>
> >
>
> Hi Akash,
> Can you add this patch to your tree, as Rob indicated above?
>
...applied it to the Qualcomm "drivers" tree for 5.9.
Thanks for the patch Randy and thanks for the Ack, Rob.
Regards,
Bjorn
> thanks.
> --
> ~Randy
>
Powered by blists - more mailing lists