linux-kernel - Re: [PATCH v5 2/2] devicetree: hwmon: shtc1: Add sensirion,shtc1.yaml

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4189dcf7-fc67-29c4-6357-646071d7ded0@gtsys.com.hk>
Date:   Sun, 12 Jul 2020 07:59:03 +0800
From:   Chris Ruehl <chris.ruehl@...ys.com.hk>
To:     Rob Herring <robh@...nel.org>
Cc:     Guenter Roeck <linux@...ck-us.net>, Jack Lo <jack.lo@...ys.com.hk>,
        linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
        Rob Herring <robh+dt@...nel.org>,
        Jean Delvare <jdelvare@...e.com>, devicetree@...r.kernel.org
Subject: Re: [PATCH v5 2/2] devicetree: hwmon: shtc1: Add sensirion,shtc1.yaml

Morning,

On 11/7/2020 6:05 pm, Chris Ruehl wrote:
> 
> On 11/7/2020 12:31 am, Rob Herring wrote:
>> On Fri, 10 Jul 2020 10:15:35 +0800, Chris Ruehl wrote:
>>> Add documentation for the newly added DTS support in the shtc1 driver.
>>> To align with the drivers logic to have high precision by default
>>> a boolean sensirion,low_precision is used to switch to low precision.
>>>
>>> Signed-off-by: Chris Ruehl <chris.ruehl@...ys.com.hk>
>>> ---
>>>   .../bindings/hwmon/sensirion,shtc1.yaml       | 57 +++++++++++++++++++
>>>   1 file changed, 57 insertions(+)
>>>   create mode 100644 
>>> Documentation/devicetree/bindings/hwmon/sensirion,shtc1.yaml
>>>
>>
>>
>> My bot found errors running 'make dt_binding_check' on your patch:
>>
>> Error: 
>> Documentation/devicetree/bindings/hwmon/sensirion,shtc1.example.dts:25.13-14 
>> syntax error
>> FATAL ERROR: Unable to parse input tree
>> scripts/Makefile.lib:315: recipe for target 
>> 'Documentation/devicetree/bindings/hwmon/sensirion,shtc1.example.dt.yaml' failed
>> make[1]: *** 
>> [Documentation/devicetree/bindings/hwmon/sensirion,shtc1.example.dt.yaml] Error 1
>> make[1]: *** Waiting for unfinished jobs....
>> Makefile:1347: recipe for target 'dt_binding_check' failed
>> make: *** [dt_binding_check] Error 2
>>
>>
>> See https://patchwork.ozlabs.org/patch/1326414
>>
>> If you already ran 'make dt_binding_check' and didn't see the above
>> error(s), then make sure dt-schema is up to date:
>>
>> pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade
>>
>> Please check and re-submit.
>>
> 
> Hi Rob,
> 
> I did run the test and didn't had any Error. dt-schema 2020.06 installed from 
> git. pip3 install -e.
> 
> Can you help?
> 
> Chris

Solved, missing ";" behind reg = <0x70>

will resend.