linux-kernel - Re: [PATCH 01/20] dlb2: add skeleton for DLB 2.0 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200712155810.GC186665@kroah.com>
Date:   Sun, 12 Jul 2020 17:58:10 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Gage Eads <gage.eads@...el.com>
Cc:     linux-kernel@...r.kernel.org, arnd@...db.de,
        magnus.karlsson@...el.com, bjorn.topel@...el.com
Subject: Re: [PATCH 01/20] dlb2: add skeleton for DLB 2.0 driver

On Sun, Jul 12, 2020 at 08:43:12AM -0500, Gage Eads wrote:
> +static int dlb2_probe(struct pci_dev *pdev,
> +		      const struct pci_device_id *pdev_id)
> +{
> +	struct dlb2_dev *dlb2_dev;
> +	int ret;
> +
> +	dev_dbg(&pdev->dev, "probe\n");

ftrace is your friend.  Remove all of your debugging code now, you don't
need it anymore, especially for stuff like this where you didn't even
need it in the first place :(

Same for everywhere else in all of these patches.  I'll stop reviewing
now, someone at Intel should have caught basic stuff like this before
now, sad...

greg k-h