linux-kernel - Re: [PATCH] staging: r8188eu: remove unused members of struct xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5e3186e7-4b07-c119-2658-ebe5464a9fa7@gmail.com>
Date:   Mon, 13 Jul 2020 00:11:56 +0300
From:   Ivan Safonov <insafonov@...il.com>
To:     Larry Finger <Larry.Finger@...inger.net>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Michael Straube <straube.linux@...il.com>,
        Soumyajit Deb <debsoumyajit100@...il.com>,
        Nishka Dasgupta <nishkadg.linux@...il.com>,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: r8188eu: remove unused members of struct
 xmit_buf

On 7/12/20 8:55 PM, Larry Finger wrote:
> On 7/12/20 7:38 AM, Ivan Safonov wrote:
>> Remove unused members of struct xmit_buf: alloc_sz, ff_hwaddr,
>> dma_transfer_addr, bpending and last.
>>
>> Signed-off-by: Ivan Safonov <insafonov@...il.com>
>> ---
> 
> Have you tested this change? Previously with this driver, an unused 
> quantity was removed from one of the structs and the driver failed. 
> Apparently, the alignment of some other quantity was affected. I do not 
> think that this change would have that affect; however, you should be 
> testing whenever the changes are more than cosmetic.
> 
> Larry
> 

I have not tested this patch.

Ivan.