linux-kernel - Re: [PATCH] decompress_bunzip2: fix sizeof type in start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27660a3e38af43c9e741a4dfcdec50757c32f409.camel@perches.com>
Date:   Sun, 12 Jul 2020 14:49:44 -0700
From:   Joe Perches <joe@...ches.com>
To:     Tom Rix <trix@...hat.com>, "H. Peter Anvin" <hpa@...or.com>,
        alain@...ff.lu
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH] decompress_bunzip2: fix sizeof type in start_bunzip

On Sun, 2020-07-12 at 08:12 -0700, Tom Rix wrote:
> On 7/12/20 6:09 AM, H. Peter Anvin wrote:
> > On 2020-07-12 05:59, trix@...hat.com wrote:
> > > From: Tom Rix <trix@...hat.com>
[]
> > > So change the type in sizeof to 'unsigned int'
> > You must be kidding.
> > 
> > If you want to change it, change it to sizeof(bd->dbuf) instead, but this flag
> > is at least in my opinion a total joke. For sizeof(int) != sizeof(unsigned
> > int) is beyond bizarre, no matter how stupid the platform.
> 
> Using the actual type is more correct that using a type of the same size.

Sure.

But this hardly matters as this same type conversion
from signed to unsigned or the other way round is
_everywhere_ in the kernel.

And especially the cc of stable is unnecessary.