linux-kernel - Re: [PATCH RFC] leds: Add support for per-LED device triggers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200713011841.25904273@nic.cz>
Date:   Mon, 13 Jul 2020 01:18:41 +0200
From:   Marek Behun <marek.behun@....cz>
To:     Ondřej Jirman <megous@...ous.com>
Cc:     Pavel Machek <pavel@....cz>, linux-kernel@...r.kernel.org,
        Jacek Anaszewski <jacek.anaszewski@...il.com>,
        Dan Murphy <dmurphy@...com>,
        "open list:LED SUBSYSTEM" <linux-leds@...r.kernel.org>
Subject: Re: [PATCH RFC] leds: Add support for per-LED device triggers

On Mon, 13 Jul 2020 01:15:44 +0200
Marek Behun <marek.behun@....cz> wrote:

> On Mon, 13 Jul 2020 00:38:21 +0200
> Ondřej Jirman <megous@...ous.com> wrote:
> 
> > So after trying to use this, this seems to disallow the use of multiple HW
> > triggers per LED. That's fine by me, because using one HW sysfs configured
> > trigger per LED that use case is my proposal, but is it desireable in general?  
> 
> Why? If you register one LED and several triggers, all sharing the same
> trigger_type pointer, I think it should work.
> 
> Marek

The problem arises when I have two LEDs and two HW triggers, and the
hardware allows setting one HW trigger on both LEDs and other HW
trigger only on one LED. But this could simply be ignored - the
set_trigger function could simply return -ENOTSUPP or something.

Marek