[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20200713033313.21487-1-vulab@iscas.ac.cn>
Date: Mon, 13 Jul 2020 03:33:13 +0000
From: Xu Wang <vulab@...as.ac.cn>
To: jk@...abs.org, joel@....id.au, alistair@...ple.id.au,
eajames@...ux.ibm.com, linux-fsi@...ts.ozlabs.org
Cc: linux-kernel@...r.kernel.org, Xu Wang <vulab@...as.ac.cn>
Subject: [PATCH] fsi: fsi-occ: fix return value check in occ_probe()
In case of error, the function platform_device_register_full()
returns ERR_PTR() and never returns NULL. The NULL test in the
return value check should be replaced with IS_ERR().
Signed-off-by: Xu Wang <vulab@...as.ac.cn>
---
drivers/fsi/fsi-occ.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/fsi/fsi-occ.c b/drivers/fsi/fsi-occ.c
index 7da9c81759ac..9eeb856c8905 100644
--- a/drivers/fsi/fsi-occ.c
+++ b/drivers/fsi/fsi-occ.c
@@ -555,7 +555,7 @@ static int occ_probe(struct platform_device *pdev)
hwmon_dev_info.id = occ->idx;
hwmon_dev = platform_device_register_full(&hwmon_dev_info);
- if (!hwmon_dev)
+ if (IS_ERR(hwmon_dev))
dev_warn(dev, "failed to create hwmon device\n");
return 0;
--
2.17.1
Powered by blists - more mailing lists