[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200713182356.GA413630@bogus>
Date: Mon, 13 Jul 2020 12:23:56 -0600
From: Rob Herring <robh@...nel.org>
To: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
Cc: f.fainelli@...il.com, gregkh@...uxfoundation.org, wahrenst@....net,
p.zabel@...gutronix.de, linux-kernel@...r.kernel.org,
Ray Jui <rjui@...adcom.com>,
Scott Branden <sbranden@...adcom.com>,
bcm-kernel-feedback-list@...adcom.com,
Eric Anholt <eric@...olt.net>, linux-usb@...r.kernel.org,
linux-rpi-kernel@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, tim.gover@...pberrypi.org,
linux-pci@...r.kernel.org, helgaas@...nel.org,
andy.shevchenko@...il.com, mathias.nyman@...ux.intel.com,
lorenzo.pieralisi@....com, devicetree@...r.kernel.org
Subject: Re: [PATCH v3 1/9] dt-bindings: reset: Add a binding for the RPi
Firmware reset controller
On Fri, Jun 12, 2020 at 07:13:25PM +0200, Nicolas Saenz Julienne wrote:
> The firmware running on the RPi VideoCore can be used to reset and
> initialize HW controlled by the firmware.
>
> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@...e.de>
> Reviewed-by: Florian Fainelli <f.fainelli@...il.com>
>
> ---
> Changes since v2:
> - Add include file for reset IDs
>
> Changes since v1:
> - Correct cells binding as per Florian's comment
> - Change compatible string to be more generic
>
> .../arm/bcm/raspberrypi,bcm2835-firmware.yaml | 21 +++++++++++++++++++
> .../reset/raspberrypi,firmware-reset.h | 13 ++++++++++++
> 2 files changed, 34 insertions(+)
> create mode 100644 include/dt-bindings/reset/raspberrypi,firmware-reset.h
>
> diff --git a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> index b48ed875eb8e..23a885af3a28 100644
> --- a/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> +++ b/Documentation/devicetree/bindings/arm/bcm/raspberrypi,bcm2835-firmware.yaml
> @@ -39,6 +39,22 @@ properties:
> - compatible
> - "#clock-cells"
>
> + reset:
I'm not really thrilled how this is evolving with a node per provider.
There's no reason you can't just add #clock-cells and #reset-cells to
the parent firmware node.
I probably should have complained with the clocks node, but that's only
pending for 5.9.
The bigger issue is this stuff is just trickling in one bit at a time
which gives no context for review. What's next? Is it really a mystery
as to what functions the firmware provides? You don't have to have a
driver in place for every function.
Rob
Powered by blists - more mailing lists