linux-kernel - Re: [PATCH net-next] rtnetlink: Fix memory(net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200713.120206.428449983947812863.davem@davemloft.net>
Date:   Mon, 13 Jul 2020 12:02:06 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     chenweilong@...wei.com
Cc:     kuba@...nel.org, jiri@...lanox.com, edumazet@...gle.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] rtnetlink: Fix memory(net_device) leak when
 ->newlink fails

From: Weilong Chen <chenweilong@...wei.com>
Date: Mon, 13 Jul 2020 15:55:28 +0800

> When vlan_newlink call register_vlan_dev fails, it might return error
> with dev->reg_state = NETREG_UNREGISTERED. The rtnl_newlink should
> free the memory. But currently rtnl_newlink only free the memory which
> state is NETREG_UNINITIALIZED.
 ...
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Weilong Chen <chenweilong@...wei.com>

This needs a Fixes: tag.

Also, can't this bug happen in mainline too?  It's a bug fix and therefore
should target 'net' instead of 'net-next'.