linux-kernel - Re: [PATCH 2/2] Crypto/chcr: Fix some pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 13 Jul 2020 22:00:30 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Christophe Jaillet <christophe.jaillet@...adoo.fr>,
        linux-crypto@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Ayush Sawal <ayush.sawal@...lsio.com>,
        "David S. Miller" <davem@...emloft.net>,
        Herbert Xu <herbert@...dor.apana.org.au>,
        Rohit Maheshwari <rohitm@...lsio.com>,
        Vinay Kumar Yadav <vinay.yadav@...lsio.com>
Subject: Re: [PATCH 2/2] Crypto/chcr: Fix some pr_xxx messages

…
> +++ b/drivers/crypto/chelsio/chcr_algo.c
> @@ -1224,7 +1224,7 @@ static int chcr_handle_cipher_resp(struct skcipher_request *req,
>  	wrparam.bytes = bytes;
>  	skb = create_cipher_wr(&wrparam);
>  	if (IS_ERR(skb)) {
> -		pr_err("chcr : %s : Failed to form WR. No memory\n", __func__);
> +		pr_err("%s : Failed to form WR. No memory\n", __func__);
>  		err = PTR_ERR(skb);
>  		goto unmap;
>  	}

I suggest to omit also a space character before the colon in such format strings.

+		pr_err("%s: Failed to form WR. No memory\n", __func__);


Would you like to apply any further fine-tuning around affected error messages?

Regards,
Markus