linux-kernel - Re: [PATCH] phy: allwinner: Make PHY_SUN6I_MIPI_DPHY depend on COMMON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200713051102.GU34333@vkoul-mobl>
Date:   Mon, 13 Jul 2020 10:41:02 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc:     Kishon Vijay Abraham I <kishon@...com>,
        Heiko Stuebner <heiko@...ech.de>, linux-kernel@...r.kernel.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] phy: allwinner: Make PHY_SUN6I_MIPI_DPHY depend on
 COMMON_CLK

On 07-07-20, 17:22, Tiezhu Yang wrote:
> When CONFIG_ARCH_SUNXI is not set but CONFIG_COMPILE_TEST=y,
> CONFIG_HAVE_CLK=y, CONFIG_HAVE_LEGACY_CLK=y, there exists
> the following build errors with CONFIG_PHY_SUN6I_MIPI_DPHY=y:
> 
> drivers/phy/allwinner/phy-sun6i-mipi-dphy.o: In function `sun6i_dphy_init':
> phy-sun6i-mipi-dphy.c:(.text+0x320): undefined reference to `clk_set_rate_exclusive'
> drivers/phy/allwinner/phy-sun6i-mipi-dphy.o: In function `sun6i_dphy_exit':
> phy-sun6i-mipi-dphy.c:(.text+0x2c8): undefined reference to `clk_rate_exclusive_put'
> 
> clk_set_rate_exclusive() and clk_rate_exclusive_put() are defined
> in drivers/clk/clk.c, this file is built under CONFIG_COMMON_CLK,
> so in order to build drivers/phy/allwinner/phy-sun6i-mipi-dphy.c
> successful used with various configs, CONFIG_PHY_SUN6I_MIPI_DPHY
> should depend on CONFIG_COMMON_CLK.

Applied, thanks

-- 
~Vinod